Differential D48471

fusefs: add more tests for buggy FUSE servers
ClosedPublic
Actions

Authored by asomers on Jan 15 2025, 8:22 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 14, 5:20 AM

	Unknown Object (File)
	Tue, Oct 13, 8:03 PM

	Unknown Object (File)
	Tue, Oct 13, 7:46 PM

	Unknown Object (File)
	Tue, Oct 13, 7:15 PM

	Unknown Object (File)
	Tue, Oct 13, 2:44 PM

	Unknown Object (File)
	Wed, Oct 7, 12:55 AM

	Unknown Object (File)
	Tue, Oct 6, 6:06 PM

	Unknown Object (File)
	Tue, Oct 6, 2:49 PM

Subscribers

Details

Reviewers

Commits

rG5a8d8ffd7c8d: fusefs: add more checks for buggy FUSE servers
rGf1ec3bc06ed2: fusefs: add more checks for buggy FUSE servers

Summary

If a FUSE file system is NFS-exported (either by a kernel or userspace NFS server), then it must support FUSE_LOOKUP operations for ".". But if the response reports a different nodeid than the request, that's very bad. Fail the operation and warn the operator.

In general, a FUSE file may have a distinct "nodeid" and "inode number". But it the file system is NFS-exported (either by a kernel or userspace NFS server), then those two must match, because the NFS server will do VFS_VGET operations using the inode number. If they don't match, warn the operator.

MFC after: 2 weeks
Sponsored by: ConnectWise

Test Plan

Test cases added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 61743
Build 58627: arc lint + arc unit

Event Timeline

asomers created this revision.Jan 15 2025, 8:22 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 15 2025, 8:22 PM

asomers requested review of this revision.Jan 15 2025, 8:22 PM

Harbormaster completed remote builds in B61742: Diff 149308.Jan 15 2025, 8:22 PM

Cleanup trailing whitespace

Harbormaster completed remote builds in B61743: Diff 149309.Jan 15 2025, 8:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 13 2025, 9:00 PM

Closed by commit rGf1ec3bc06ed2: fusefs: add more checks for buggy FUSE servers (authored by asomers). · Explain Why

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rGf1ec3bc06ed2: fusefs: add more checks for buggy FUSE servers.

asomers added a commit: rG5a8d8ffd7c8d: fusefs: add more checks for buggy FUSE servers.Jul 23 2025, 11:29 PM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

2 lines

19 lines

13 lines

tests/

sys/

fs/

fusefs/

last_local_modify.cc

5 lines

7 lines

106 lines

Diff 149309

sys/fs/fuse/fuse_ipc.h

Loading...

sys/fs/fuse/fuse_node.c

Loading...

sys/fs/fuse/fuse_vfsops.c

Loading...

tests/sys/fs/fusefs/last_local_modify.cc

Loading...

tests/sys/fs/fusefs/lookup.cc

Loading...

tests/sys/fs/fusefs/nfs.cc

Loading...