Page MenuHomeFreeBSD
Differential D48353

loader: Fix orb position
ClosedPublic
Actions

Authored by manu on Jan 7 2025, 9:40 AM.
Tags
None
Referenced Files
F156935307: D48353.id148965.diff
Sun, May 17, 11:41 AM
F156935284: D48353.id148965.diff
Sun, May 17, 11:41 AM
F156908611: D48353.id148861.diff
Sun, May 17, 6:53 AM
Unknown Object (File)
Sat, May 16, 7:34 PM
Unknown Object (File)
Thu, May 14, 2:40 PM
Unknown Object (File)
Thu, May 14, 9:12 AM
Unknown Object (File)
Thu, May 14, 12:54 AM
Unknown Object (File)
Mon, May 11, 4:49 PM
View All 88 Files
Subscribers
dab
imp
zarychtam_plan-b.pwste.edu.pl

Details

Reviewers
tsoome
imp
Group Reviewers
Loader
Commits
rG1b4e11713153: loader: Fix orb position
Summary

Fix the orb position to be aligned with the menu

Sponsored by: Beckhoff Automation GmbH & Co. KG

Test Plan

Before : https://people.freebsd.org/~manu/IMG_20250107_095445.jpg
After : https://people.freebsd.org/~manu/IMG_20250107_095722.jpg

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61535
Build 58419: arc lint + arc unit

Event Timeline

manu created this revision.Jan 7 2025, 9:40 AM
Herald added subscribers: dab, imp. · View Herald TranscriptJan 7 2025, 9:40 AM
manu requested review of this revision.Jan 7 2025, 9:40 AM
Harbormaster completed remote builds in B61535: Diff 148861.Jan 7 2025, 9:40 AM
manu added a child revision: D48354: loader: Rework kernel menu section.Jan 7 2025, 9:40 AM
manu edited the test plan for this revision. (Show Details)Jan 7 2025, 9:41 AM
manu added a reviewer: Loader.
tsoome accepted this revision.Jan 7 2025, 10:10 AM
This revision is now accepted and ready to land.Jan 7 2025, 10:10 AM
imp accepted this revision.Jan 7 2025, 11:02 AM
Closed by commit rG1b4e11713153: loader: Fix orb position (authored by manu). · Explain WhyJan 9 2025, 7:12 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG1b4e11713153: loader: Fix orb position.
zarychtam_plan-b.pwste.edu.pl added a subscriber: zarychtam_plan-b.pwste.edu.pl.EditedFeb 26 2025, 4:13 PM

It looks like someone has to fix also:
gfx-beastie.lua
gfx-beastiebw.lua
gfx-fbsdbw.lua
gfx-orbbw.lua

See PR 285044
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285044

zarychtam_plan-b.pwste.edu.pl added inline comments.Feb 26 2025, 5:39 PM
stand/lua/drawer.lua
473

In the case of gfx-beastie{,bw}.lua switching back to y = 4 fixes the issue reported in bug 285044.

Revision Contents
Changeset List

PathSize
stand/
lua/
4 lines
2 lines
2 lines

Diff 148861

View Options

stand/lua/drawer.lua

Loading...
View Options

stand/lua/gfx-orb.lua

Loading...
View Options

stand/lua/gfx-orbbw.lua

Loading...