Page MenuHomeFreeBSD

ifconfig: make -vht work
ClosedPublic

Authored by bz on Sun, Jan 5, 12:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 10, 7:07 PM
Unknown Object (File)
Fri, Jan 10, 4:16 AM
Unknown Object (File)
Thu, Jan 9, 10:00 AM
Unknown Object (File)
Thu, Jan 9, 7:55 AM
Unknown Object (File)
Thu, Jan 9, 5:36 AM
Unknown Object (File)
Tue, Jan 7, 7:34 PM
Unknown Object (File)
Tue, Jan 7, 3:54 PM
Unknown Object (File)
Tue, Jan 7, 1:12 PM
Subscribers

Details

Summary

Also hide the other vht options on -vht and only show vht40/80/160/80p80
when vht is enabled.

While here fix some whitespace and comments.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 61508
Build 58392: arc lint + arc unit

Event Timeline

bz requested review of this revision.Sun, Jan 5, 12:31 PM
pi retitled this revision from ifcinfig: make -vht work to ifconfig: make -vht work.Sun, Jan 5, 12:41 PM

It seems to be common in other cases to print the -ve values under else if (verbose), does that make sense here?

It seems to be common in other cases to print the -ve values under else if (verbose), does that make sense here?

I think it's okay to leave the vht stuff more verbose for now until we've got everything else lined up OK.
As long as we get some user feedback and then address this before we cut 15-REL. :-)

This revision is now accepted and ready to land.Mon, Jan 6, 7:29 PM

As hinted by @emaste hide the -vht under ifconfig -v as well to be
consistent. I'd rather do it once and for all now than having to
start again. I am typing -v anyway all the time while developing
(given not even pre-vht stuff is all consistent as we have pointed
out in the other review).

This revision now requires review to proceed.Tue, Jan 7, 2:13 PM
This revision is now accepted and ready to land.Tue, Jan 7, 3:26 PM
This revision was automatically updated to reflect the committed changes.