Page MenuHomeFreeBSD
Differential D48300

libusb: hotplug, use events instead of a timer when possible
ClosedPublic
Actions

Authored by bapt on Fri, Jan 3, 1:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 16, 2:12 PM
Unknown Object (File)
Thu, Jan 16, 11:17 AM
Unknown Object (File)
Thu, Jan 16, 11:17 AM
Unknown Object (File)
Thu, Jan 16, 11:17 AM
Unknown Object (File)
Thu, Jan 16, 11:17 AM
Unknown Object (File)
Thu, Jan 16, 11:16 AM
Unknown Object (File)
Thu, Jan 16, 11:16 AM
Unknown Object (File)
Thu, Jan 16, 11:16 AM
View All 31 Files
Subscribers
imp
mohammad_fbsdphab_thelightbird.com

Details

Reviewers
emaste
kevans
Group Reviewers
USB
Commits
rG9dc96d8bc3f2: libusb: hotplug, use events instead of a timer when possible
Summary

Try to fetch events from nlsysevent or devd to determine when
to scan the usb bus for devices addition or removal.
if none are available fallback on the regular timer based (4s)
scanner

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 61478
Build 58362: arc lint + arc unit

Event Timeline

bapt created this revision.Fri, Jan 3, 1:34 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jan 3, 1:34 PM
bapt requested review of this revision.Fri, Jan 3, 1:34 PM
Harbormaster completed remote builds in B61477: Diff 148720.Fri, Jan 3, 1:34 PM
bapt added a reviewer: emaste.Fri, Jan 3, 1:35 PM
bapt updated this revision to Diff 148721.Fri, Jan 3, 1:36 PM

push the right patch

Harbormaster completed remote builds in B61478: Diff 148721.Fri, Jan 3, 1:36 PM
bapt updated this revision to Diff 148722.Fri, Jan 3, 1:38 PM

unexpected stuff added

Harbormaster completed remote builds in B61479: Diff 148722.Fri, Jan 3, 1:38 PM
bapt added a reviewer: kevans.Fri, Jan 3, 2:34 PM
bapt updated this revision to Diff 148763.Sat, Jan 4, 10:23 AM

rebase

Harbormaster completed remote builds in B61499: Diff 148763.Sat, Jan 4, 10:23 AM
bapt added a reviewer: USB.Sat, Jan 4, 4:41 PM
mohammad_fbsdphab_thelightbird.com added a subscriber: mohammad_fbsdphab_thelightbird.com.Sun, Jan 5, 4:25 PM
mohammad_fbsdphab_thelightbird.com added inline comments.Sun, Jan 5, 4:46 PM
lib/libusb/libusb10_hotplug.c
57

Hi @bapt,

According to devd(8) '/var/run/devd.pipe' is deprecated in favor for '/var/run/devd.seqpacket.pipe', any reason for still using it here ?

kevans added a comment.Sun, Jan 5, 8:49 PM

Looks fine in principle

lib/libusb/libusb10_hotplug.c
178–179

This doesn't seem like it would work?

194

IMO "ignore any error" should just be a (void) cast for the return vaule, but I don't feel strongly about it.

194

Where is timeout coming from here? With this and the above, kinda seems like something went wrong with the patch.

emaste added inline comments.Mon, Jan 6, 4:14 PM
lib/libusb/libusb10_hotplug.c
194

Yeah not a huge issue but I agree (void)poll(...) is both a programmer-readable and machine-readable way to indicate that errors are intentionally ignored.

bapt updated this revision to Diff 148858.Tue, Jan 7, 7:55 AM

fix bad rebase
switch from sock_stream to sock_seqpacket for devd's pipe

Harbormaster completed remote builds in B61534: Diff 148858.Tue, Jan 7, 7:55 AM
bapt marked 4 inline comments as done.Tue, Jan 7, 7:55 AM
bapt added inline comments.
lib/libusb/libusb10_hotplug.c
178–179

sorry bad rebase

194

bad rebase as well

kevans accepted this revision as: kevans.Wed, Jan 8, 8:30 PM
This revision is now accepted and ready to land.Wed, Jan 8, 8:30 PM
bapt updated this revision to Diff 148968.Thu, Jan 9, 9:13 AM
bapt marked an inline comment as done.

actually read the informations bassed in the sockets to avoid poll looping forever
on libusb_exit close the sockets if any to provide immediate shutdown on the hotplug thread.

fallback on the timer based method when something goes wrong

This revision now requires review to proceed.Thu, Jan 9, 9:13 AM
Harbormaster completed remote builds in B61594: Diff 148968.Thu, Jan 9, 9:13 AM
kevans accepted this revision as: kevans.Thu, Jan 16, 2:07 PM
This revision is now accepted and ready to land.Thu, Jan 16, 2:07 PM
Closed by commit rG9dc96d8bc3f2: libusb: hotplug, use events instead of a timer when possible (authored by bapt). · Explain WhyThu, Jan 16, 2:11 PM
This revision was automatically updated to reflect the committed changes.
bapt added a commit: rG9dc96d8bc3f2: libusb: hotplug, use events instead of a timer when possible.

Revision Contents
Changeset List

PathSize
lib/
libusb/
16 lines
1 line
102 lines
usr.sbin/
powerd/
2 lines

Diff 148721

View Options

lib/libusb/libusb10.h

Loading...
View Options

lib/libusb/libusb10.c

Loading...
View Options

lib/libusb/libusb10_hotplug.c

Loading...
View Options

usr.sbin/powerd/powerd.c

Loading...