Differential D48023

cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean
ClosedPublic
Actions

Authored by jhb on Dec 10 2024, 7:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Mar 4, 5:07 PM

	Unknown Object (File)
	Tue, Mar 4, 7:59 AM

	Unknown Object (File)
	Mon, Mar 3, 9:57 PM

	Unknown Object (File)
	Mon, Mar 3, 10:17 AM

	Unknown Object (File)
	Sun, Mar 2, 12:14 PM

	Unknown Object (File)
	Sat, Feb 22, 5:31 AM

	Unknown Object (File)
	Feb 19 2025, 8:58 PM

	Unknown Object (File)
	Feb 5 2025, 4:41 PM

View All 32 Files

Subscribers

Details

Reviewers

Commits

rG939bcd2c20b4: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean
rG0e742cc77454: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean

Summary

This is intended to clean state of a thread at the end of its
lifecycle during wait(), not the beginning of its life cycle.

Sponsored by: AFRL, DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 61462
Build 58346: arc lint + arc unit

Event Timeline

jhb created this revision.Dec 10 2024, 7:46 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 10 2024, 7:46 PM

jhb requested review of this revision.Dec 10 2024, 7:46 PM

jhb added a parent revision: D48022: cpu_machdep.9: New manpage describing the semantics of several cpu_*.

Harbormaster completed remote builds in B61075: Diff 147790.Dec 10 2024, 7:46 PM

amd64 cpu_set_upcall() also calls cpu_thread_clean(), basically for the fresh thread. I suspect this call was copied.

kib accepted this revision.Dec 11 2024, 3:46 PM

This revision is now accepted and ready to land.Dec 11 2024, 3:46 PM

In D48023#1094794, @kib wrote:

amd64 cpu_set_upcall() also calls cpu_thread_clean(), basically for the fresh thread. I suspect this call was copied.

Oof, so does i386. Not sure how I missed those. Thanks.

Remove from cpu_set_upcall

This revision now requires review to proceed.Jan 2 2025, 5:29 PM

Harbormaster completed remote builds in B61462: Diff 148681.Jan 2 2025, 5:29 PM

kib accepted this revision.Jan 3 2025, 11:45 AM

This revision is now accepted and ready to land.Jan 3 2025, 11:45 AM

Closed by commit rG0e742cc77454: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean (authored by jhb). · Explain WhyJan 3 2025, 4:03 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0e742cc77454: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean.

jhb added a commit: rG939bcd2c20b4: cpu_set_upcall / linux_clone_thread: Remove calls to cpu_thread_clean.Mon, Mar 3, 4:58 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

10 lines

compat/

linux/

2 lines

i386/

i386/

10 lines

Diff 148681

sys/amd64/amd64/vm_machdep.c

This file was added.

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				# $FreeBSD$

				PACKAGE= ${TESTBASE}/usr.bin/sponge

				TESTSDIR= ${TESTSBASE}/usr.bin/sponge/tests

				ATF_TESTS_SH= cp_test

				.include <bsd.test.mk>

sys/compat/linux/linux_fork.c

This file was added.

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				# $FreeBSD$

				PACKAGE= ${TESTBASE}/usr.bin/sponge

				TESTSDIR= ${TESTSBASE}/usr.bin/sponge/tests

				ATF_TESTS_SH= cp_test

				.include <bsd.test.mk>

sys/i386/i386/vm_machdep.c

This file was added.

Property	Old Value	New Value
svn:eol-style	null	native \ No newline at end of property
svn:keywords	null	FreeBSD=%H \ No newline at end of property
svn:mime-type	null	text/plain \ No newline at end of property

				# $FreeBSD$

				PACKAGE= ${TESTBASE}/usr.bin/sponge

				TESTSDIR= ${TESTSBASE}/usr.bin/sponge/tests

				ATF_TESTS_SH= cp_test

				.include <bsd.test.mk>