sdhci: add missing bus_add_child DEVMETHOD.
ClosedPublic
Actions

Authored by bz on Dec 19 2024, 10:22 PM.

Details

Reviewers

jhb
imp

Commits

rGd7c69a344864: sdhci: add missing bus_add_child DEVMETHOD.

Summary

Add the missing bus_add_child DEVMETHOD. This is needed for the RPi5
running with a MMCCAM kernel and the worproject/rpi5-uefi to avoid a
kernel panic on boot when SDIO tries to attach to a 'Intel Bay Trail'
controller.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 61271
Build 58155: arc lint + arc unit

Event Timeline

bz requested review of this revision.Dec 19 2024, 10:22 PM

bz created this revision.

Harbormaster completed remote builds in B61271: Diff 148260.Dec 19 2024, 10:22 PM

I wonder if other SDHCI front ends need this?
Regardless, it certainly can't hurt.

This revision is now accepted and ready to land.Dec 19 2024, 10:34 PM

In D48152#1097986, @imp wrote:

I wonder if other SDHCI front ends need this?
Regardless, it certainly can't hurt.

Question might be "need" as in it's not there or "need" as in "hardware with SDIO on it exists"?

Closed by commit rGd7c69a344864: sdhci: add missing bus_add_child DEVMETHOD. (authored by bz). · Explain WhyDec 20 2024, 7:20 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGd7c69a344864: sdhci: add missing bus_add_child DEVMETHOD..

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

sdhci_acpi.c

1 line

Diff 148260

View Options

sys/dev/sdhci/sdhci_acpi.c

sdhci: add missing bus_add_child DEVMETHOD.ClosedPublicActions