Page MenuHomeFreeBSD
Differential D5812

hyperv/vmbus: change channel_msg_lock to default mtx
ClosedPublic
Actions

Authored by howard0su_gmail.com on Apr 2 2016, 7:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 27, 12:51 AM
Unknown Object (File)
Mon, Mar 16, 1:18 AM
Unknown Object (File)
Sun, Mar 15, 8:44 PM
Unknown Object (File)
Sun, Mar 15, 1:01 PM
Unknown Object (File)
Sat, Mar 14, 7:21 PM
Unknown Object (File)
Wed, Mar 11, 9:26 PM
Unknown Object (File)
Mon, Mar 9, 3:10 PM
Unknown Object (File)
Mon, Mar 9, 1:45 AM
View All Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
honzhan_microsoft.com
decui_microsoft.com
sepherosa_gmail.com
Commits
rS297635: hyperv/vmbus: Use default mtx for channel message queue
Summary

It is not necessary to be a spin lock. Also we cannot
call sema_post when holding a spin lock, which can
cause panic.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3096
Build 3128: arc lint + arc unit

Event Timeline

howard0su_gmail.com updated this revision to Diff 14823.Apr 2 2016, 7:19 AM
howard0su_gmail.com retitled this revision from to hyperv/vmbus: change channel_msg_lock to default mtx.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptApr 2 2016, 7:19 AM
decui_microsoft.com accepted this revision.Apr 2 2016, 2:35 PM
decui_microsoft.com added a reviewer: decui_microsoft.com.
This revision is now accepted and ready to land.Apr 2 2016, 2:35 PM
decui_microsoft.com added reviewers: sepherosa_gmail.com, honzhan_microsoft.com.Apr 2 2016, 2:36 PM
sepherosa_gmail.com accepted this revision.Apr 5 2016, 1:22 AM
sepherosa_gmail.com edited edge metadata.
Closed by commit rS297635: hyperv/vmbus: Use default mtx for channel message queue (authored by sephe). · Explain WhyApr 7 2016, 5:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
hyperv/
vmbus/
24 lines
16 lines
14 lines

Diff 14823

View Options

sys/dev/hyperv/vmbus/hv_channel.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Loading...
View Options

sys/dev/hyperv/vmbus/hv_connection.c

Loading...