Remove SI_SUB_DONE
ClosedPublic
Actions

Authored by zlei on Dec 4 2024, 4:14 PM.

Details

Reviewers

cperciva
mhorne
imp

Commits

rG42d4bcc6c560: sys/sys/kernel.h: Remove SI_SUB_DONE
rG81f9d3b11f31: sys/sys/kernel.h: Remove SI_SUB_DONE

Summary

It has been unused since 9a7add6d01f3.

Fixes: 9a7add6d01f3 init_main: Switch from sysinit array to SLIST
MFC after: 2 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Dec 4 2024, 4:14 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 4 2024, 4:14 PM

zlei requested review of this revision.Dec 4 2024, 4:14 PM

mhorne accepted this revision.Dec 4 2024, 4:53 PM

This revision is now accepted and ready to land.Dec 4 2024, 4:53 PM

This did go away where indicated, and is no longer used and appears to not be needed (kldload works, eh?)

In D47915#1092672, @imp wrote:

This did go away where indicated, and is no longer used and appears to not be needed (kldload works, eh?)

Yes. kldload directly execute sysinit tasks of a dynamically loaded module. SI_SUB_DONE was used by mi_startup(). Only sysinit tasks of statically linked or pre-loaded kernel modules are executed by mi_startup() .

Closed by commit rG81f9d3b11f31: sys/sys/kernel.h: Remove SI_SUB_DONE (authored by zlei). · Explain WhyDec 31 2024, 4:05 PM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG81f9d3b11f31: sys/sys/kernel.h: Remove SI_SUB_DONE.

zlei added a commit: rG42d4bcc6c560: sys/sys/kernel.h: Remove SI_SUB_DONE.Jan 14 2025, 4:22 AM

Revision Contents
Changeset List

Path

Size

sys/

kernel.h

1 line

Diff 147482

View Options

sys/sys/kernel.h

	Show First 20 Lines • Show All 79 Lines • ▼ Show 20 Lines
	* These numbers are arbitrary and are chosen ONLY for ordering; the			* These numbers are arbitrary and are chosen ONLY for ordering; the
	* enumeration values are explicit rather than implicit to provide			* enumeration values are explicit rather than implicit to provide
	* for binary compatibility with inserted elements.			* for binary compatibility with inserted elements.
	*			*
	* The SI_SUB_LAST value must have the highest lexical value.			* The SI_SUB_LAST value must have the highest lexical value.
	*/			*/
	enum sysinit_sub_id {			enum sysinit_sub_id {
	SI_SUB_DUMMY = 0x0000000, /* not executed; for linker*/			SI_SUB_DUMMY = 0x0000000, /* not executed; for linker*/
	SI_SUB_DONE = 0x0000001, /* processed*/
	SI_SUB_TUNABLES = 0x0700000, /* establish tunable values */			SI_SUB_TUNABLES = 0x0700000, /* establish tunable values */
	SI_SUB_COPYRIGHT = 0x0800001, /* first use of console*/			SI_SUB_COPYRIGHT = 0x0800001, /* first use of console*/
	SI_SUB_VM = 0x1000000, /* virtual memory system init */			SI_SUB_VM = 0x1000000, /* virtual memory system init */
	SI_SUB_COUNTER = 0x1100000, /* counter(9) is initialized */			SI_SUB_COUNTER = 0x1100000, /* counter(9) is initialized */
	SI_SUB_KMEM = 0x1800000, /* kernel memory*/			SI_SUB_KMEM = 0x1800000, /* kernel memory*/
	SI_SUB_HYPERVISOR = 0x1A40000, /*			SI_SUB_HYPERVISOR = 0x1A40000, /*
	* Hypervisor detection and			* Hypervisor detection and
	* virtualization support			* virtualization support
	▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines

Remove SI_SUB_DONEClosedPublicActions