Page MenuHomeFreeBSD
Differential D47915

Remove SI_SUB_DONE
ClosedPublic
Actions

Authored by zlei on Dec 4 2024, 4:14 PM.
Tags
None
Referenced Files
F111389140: D47915.id147482.diff
Mon, Mar 3, 4:17 AM
F111362455: D47915.id147482.diff
Sun, Mar 2, 8:54 PM
F111352392: D47915.id148604.diff
Sun, Mar 2, 5:56 PM
F111347470: D47915.id.diff
Sun, Mar 2, 4:26 PM
F111345335: D47915.id148604.diff
Sun, Mar 2, 3:56 PM
F111345034: D47915.id.diff
Sun, Mar 2, 3:50 PM
F111344416: D47915.id147482.diff
Sun, Mar 2, 3:38 PM
F111340110: D47915.diff
Sun, Mar 2, 2:17 PM
View All 19 Files
Subscribers
imp

Details

Reviewers
cperciva
mhorne
imp
Commits
rG42d4bcc6c560: sys/sys/kernel.h: Remove SI_SUB_DONE
rG81f9d3b11f31: sys/sys/kernel.h: Remove SI_SUB_DONE
Summary

It has been unused since 9a7add6d01f3.

Fixes: 9a7add6d01f3 init_main: Switch from sysinit array to SLIST
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zlei created this revision.Dec 4 2024, 4:14 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 4 2024, 4:14 PM
zlei requested review of this revision.Dec 4 2024, 4:14 PM
mhorne accepted this revision.Dec 4 2024, 4:53 PM
This revision is now accepted and ready to land.Dec 4 2024, 4:53 PM
imp accepted this revision.Dec 4 2024, 10:19 PM

This did go away where indicated, and is no longer used and appears to not be needed (kldload works, eh?)

zlei added a comment.Dec 6 2024, 11:52 AM
In D47915#1092672, @imp wrote:

This did go away where indicated, and is no longer used and appears to not be needed (kldload works, eh?)

Yes. kldload directly execute sysinit tasks of a dynamically loaded module. SI_SUB_DONE was used by mi_startup(). Only sysinit tasks of statically linked or pre-loaded kernel modules are executed by mi_startup() .

Closed by commit rG81f9d3b11f31: sys/sys/kernel.h: Remove SI_SUB_DONE (authored by zlei). · Explain WhyDec 31 2024, 4:05 PM
This revision was automatically updated to reflect the committed changes.
zlei added a commit: rG81f9d3b11f31: sys/sys/kernel.h: Remove SI_SUB_DONE.
zlei added a commit: rG42d4bcc6c560: sys/sys/kernel.h: Remove SI_SUB_DONE.Jan 14 2025, 4:22 AM

Revision Contents
Changeset List

PathSize
sys/
sys/
1 line

Diff 147482

View Options

sys/sys/kernel.h

Loading...