Page MenuHomeFreeBSD

dtrace: Avoid excessive pcpu allocations
ClosedPublic

Authored by markj on Mon, Nov 18, 11:17 PM.
Tags
None
Referenced Files
F103252323: D47667.diff
Fri, Nov 22, 4:02 PM
Unknown Object (File)
Wed, Nov 20, 11:45 AM
Unknown Object (File)
Tue, Nov 19, 8:26 AM
Unknown Object (File)
Tue, Nov 19, 7:43 AM
Unknown Object (File)
Tue, Nov 19, 5:37 AM
Unknown Object (File)
Tue, Nov 19, 4:53 AM
Subscribers

Details

Summary

We were previously allocating MAXCPU structures for several purposes,
but this is generally unnecessary and is quite excessive. We already
are careful to allocate only as many per-CPU tracing buffers as needed;
extend this to other allocations.

For example, in a 2-vCPU VM, the size of a consumer state structure
drops from 64KB to 128B. The size of the per-consumer dts_buffer and
dts_aggbuffer arrays shrink similarly.

No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60673
Build 57557: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Fri, Nov 22, 2:05 PM
This revision was automatically updated to reflect the committed changes.