Page MenuHomeFreeBSD
Differential D47642

ktrace: Do not set args and envs as default
AbandonedPublic
Actions

Authored by jlduran on Sat, Nov 16, 11:31 PM.
Tags
None
Referenced Files
F103139423: D47642.diff
Thu, Nov 21, 12:56 PM
F103096782: D47642.id.diff
Wed, Nov 20, 10:36 PM
Unknown Object (File)
Tue, Nov 19, 9:32 AM
Unknown Object (File)
Mon, Nov 18, 5:33 PM
Unknown Object (File)
Mon, Nov 18, 10:49 AM
Unknown Object (File)
Mon, Nov 18, 6:08 AM
Unknown Object (File)
Sun, Nov 17, 1:12 AM
Subscribers
imp

Details

Reviewers
emaste
glebius
Summary

Do not define KTRFAC_ARGS and KTRFAC_ENVS as default points.

Reported by: Jenkins
Fixes: 65a4daeaf324 ("ktrace: log execve(2) arguments and environment")

Test Plan
/usr/tests # kyua test bin/sh/parameters/functional_test:mail1
bin/sh/parameters/functional_test:mail1  ->  passed  [0.013s]

Results file id is usr_tests.20241116-232707-755748
Results saved to /root/.kyua/store/results.usr_tests.20241116-232707-755748.db

1/1 passed (0 broken, 0 failed, 0 skipped)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60636
Build 57520: arc lint + arc unit

Event Timeline

jlduran created this revision.Sat, Nov 16, 11:31 PM
Herald added a subscriber: imp. · View Herald TranscriptSat, Nov 16, 11:31 PM
Harbormaster completed remote builds in B60636: Diff 146605.Sat, Nov 16, 11:31 PM
jlduran requested review of this revision.Sat, Nov 16, 11:31 PM
jlduran added a comment.Sat, Nov 16, 11:33 PM

Revision D47127 broke the test:
https://ci.freebsd.org/view/Test/job/FreeBSD-main-amd64-test/25696/testReport/junit/bin.sh.parameters/functional_test/mail1/

Due to exposing ENVS in the ktrace by default.
I think this is the fix. Otherwise, the fix will be to document that a and e are now part of the default set, and fixing the mail test.

Thank you!

jlduran added a comment.Sun, Nov 17, 5:47 PM

Fixed in aab7f19974a27cac3c1088f486074c05bf95017a. Will submit the change in the manual separately. Thank you!

jlduran added a comment.Sun, Nov 17, 5:55 PM

Submitted as D47648.

jlduran abandoned this revision.Sun, Nov 17, 5:56 PM

Revision Contents
Changeset List

PathSize
usr.bin/
ktrace/
6 lines

Diff 146605

View Options

usr.bin/ktrace/ktrace.h

Loading...