Page MenuHomeFreeBSD
Differential D47550

netlink: check buffer length fits into u_int
ClosedPublic
Actions

Authored by glebius on Nov 13 2024, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 5:18 PM
Unknown Object (File)
Feb 5 2025, 2:29 AM
Unknown Object (File)
Feb 4 2025, 8:19 AM
Unknown Object (File)
Jan 18 2025, 9:11 PM
Unknown Object (File)
Jan 18 2025, 4:58 AM
Unknown Object (File)
Jan 10 2025, 2:05 AM
Unknown Object (File)
Dec 12 2024, 7:31 AM
Unknown Object (File)
Dec 8 2024, 7:42 AM
View All 19 Files
Subscribers
imp

Details

Reviewers
melifaro
Group Reviewers
network
Commits
rG0601c0f989f2: netlink: check buffer length fits into u_int
Summary

We may increase it to size_t later, KPI allows that already, but
doesn't seem to be needed today.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60529
Build 57413: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
netlink/
3 lines

Diff 146381

View Options

sys/netlink/netlink_io.c

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines
static bool nl_process_nbuf(struct nl_buf *nb, struct nlpcb *nlp); static bool nl_process_nbuf(struct nl_buf *nb, struct nlpcb *nlp);
struct nl_buf * struct nl_buf *
nl_buf_alloc(size_t len, int mflag) nl_buf_alloc(size_t len, int mflag)
{ {
struct nl_buf *nb; struct nl_buf *nb;
KASSERT(len > 0 && len <= UINT_MAX, ("%s: invalid length %zu",
__func__, len));
nb = malloc(sizeof(struct nl_buf) + len, M_NETLINK, mflag); nb = malloc(sizeof(struct nl_buf) + len, M_NETLINK, mflag);
if (__predict_true(nb != NULL)) { if (__predict_true(nb != NULL)) {
nb->buflen = len; nb->buflen = len;
nb->datalen = nb->offset = 0; nb->datalen = nb->offset = 0;
} }
return (nb); return (nb);
} }
▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines