Differential D47546

sys/powerpc: cleanup device driver module setup
AbandonedPublic
Actions

Authored by ehem_freebsd_m5p.com on Nov 13 2024, 9:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 27, 3:00 PM

	Unknown Object (File)
	Sun, Oct 26, 5:28 PM

	Unknown Object (File)
	Thu, Oct 16, 1:31 AM

	Unknown Object (File)
	Tue, Oct 14, 6:11 AM

	Unknown Object (File)
	Fri, Oct 10, 12:18 AM

	Unknown Object (File)
	Thu, Oct 9, 5:24 PM

	Unknown Object (File)
	Wed, Oct 1, 2:19 AM

	Unknown Object (File)
	Sep 28 2025, 5:37 PM

View All 46 Files

Subscribers

Details

Reviewers

Summary

Convert large numbers of instances of overt driver_t structures to using
the DEFINE_CLASS_0() macro. Greater consistency should reduce future
errors. Convert several uses of '{ 0, 0 }' driver method list ends to
DEVMETHOD_END macro.

Small amounts of similar cleanup to similar macros. The opal_sensor
module had omitted the sentinal from the table. That had likely been
functioning due to dumb luck for some time.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60525
Build 57409: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Nov 13 2024, 9:50 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 13 2024, 9:50 PM

ehem_freebsd_m5p.com requested review of this revision.Nov 13 2024, 9:50 PM

Harbormaster completed remote builds in B60525: Diff 146377.Nov 13 2024, 9:50 PM

ehem_freebsd_m5p.com abandoned this revision.Dec 13 2024, 3:28 AM

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

amigaone/

6 lines

6 lines

cpufreq/

9 lines

10 lines

9 lines

9 lines

10 lines

include/

3 lines

mambo/

6 lines

10 lines

mikrotik/

6 lines

mpc85xx/

9 lines

ds1553_bus_fdt.c

9 lines

9 lines

7 lines

8 lines

9 lines

9 lines

mpc85xx_cache.c

7 lines

7 lines

7 lines

platform_mpc85xx.c

16 lines

ofw/

3 lines

7 lines

powermac/

8 lines

8 lines

10 lines

9 lines

6 lines

9 lines

9 lines

9 lines

9 lines

10 lines

10 lines

9 lines

15 lines

10 lines

27 lines

10 lines

8 lines

10 lines

9 lines

powernv/

13 lines

6 lines

7 lines

7 lines

10 lines

15 lines

platform_powernv.c

3 lines

12 lines

ps3/

6 lines

9 lines

6 lines

7 lines

10 lines

10 lines

9 lines

pseries/

7 lines

6 lines

6 lines

platform_chrp.c

3 lines

8 lines

6 lines

12 lines

psim/

15 lines

47 lines

openpic_iobus.c

10 lines

5 lines

Diff 146377

sys/powerpc/amigaone/cpld_a1222.c

Loading...

sys/powerpc/amigaone/cpld_x5000.c

Loading...

sys/powerpc/cpufreq/dfs.c

Loading...

sys/powerpc/cpufreq/mpc85xx_jog.c

Loading...

sys/powerpc/cpufreq/pcr.c

Loading...

sys/powerpc/cpufreq/pmcr.c

Loading...

sys/powerpc/cpufreq/pmufreq.c

Loading...

sys/powerpc/include/platformvar.h

Loading...

sys/powerpc/mambo/mambo.c

Loading...

sys/powerpc/mambo/mambo_disk.c

Loading...

sys/powerpc/mikrotik/rb_led.c

Loading...

sys/powerpc/mpc85xx/atpic.c

Loading...

sys/powerpc/mpc85xx/ds1553_bus_fdt.c

Loading...

sys/powerpc/mpc85xx/fsl_diu.c

Loading...

sys/powerpc/mpc85xx/fsl_espi.c

Loading...

sys/powerpc/mpc85xx/fsl_sata.c

Loading...

sys/powerpc/mpc85xx/i2c.c

Loading...

sys/powerpc/mpc85xx/lbc.c

Loading...

sys/powerpc/mpc85xx/mpc85xx_cache.c

Loading...

sys/powerpc/mpc85xx/mpc85xx_gpio.c

Loading...

sys/powerpc/mpc85xx/pci_mpc85xx.c

Loading...

sys/powerpc/mpc85xx/platform_mpc85xx.c

Loading...

sys/powerpc/ofw/ofw_syscons.c

Loading...

sys/powerpc/ofw/openpic_ofw.c

Loading...

sys/powerpc/powermac/ata_kauai.c

Loading...

sys/powerpc/powermac/ata_macio.c

Loading...

sys/powerpc/powermac/atibl.c

Loading...

sys/powerpc/powermac/cpcht.c

Loading...

sys/powerpc/powermac/cuda.c

Loading...

sys/powerpc/powermac/fcu.c

Loading...

sys/powerpc/powermac/grackle.c

Loading...

sys/powerpc/powermac/hrowpic.c

Loading...

sys/powerpc/powermac/kiic.c

Loading...

sys/powerpc/powermac/macgpio.c

Loading...

sys/powerpc/powermac/macio.c

Loading...

sys/powerpc/powermac/nvbl.c

Loading...

sys/powerpc/powermac/pmu.c

Loading...

sys/powerpc/powermac/pswitch.c

Loading...

sys/powerpc/powermac/smu.c

Loading...

sys/powerpc/powermac/smusat.c

Loading...

sys/powerpc/powermac/tbgpio.c

Loading...

sys/powerpc/powermac/uninorth.c

Loading...

sys/powerpc/powermac/vcoregpio.c

Loading...

sys/powerpc/powernv/opal_console.c

Loading...

sys/powerpc/powernv/opal_dev.c

Loading...

sys/powerpc/powernv/opal_flash.c

Loading...

sys/powerpc/powernv/opal_i2c.c

Loading...

sys/powerpc/powernv/opal_nvram.c

Loading...

sys/powerpc/powernv/opal_sensor.c

Loading...

sys/powerpc/powernv/platform_powernv.c

Loading...

sys/powerpc/powernv/xive.c

Loading...

sys/powerpc/ps3/ehci_ps3.c

Loading...

sys/powerpc/ps3/if_glc.c

Loading...

sys/powerpc/ps3/ohci_ps3.c

Loading...

sys/powerpc/ps3/ps3bus.c

Loading...

sys/powerpc/ps3/ps3cdrom.c

Loading...

sys/powerpc/ps3/ps3disk.c

Loading...

sys/powerpc/ps3/ps3pic.c

Loading...

sys/powerpc/pseries/phyp_console.c

Loading...

sys/powerpc/pseries/phyp_llan.c

Loading...

sys/powerpc/pseries/phyp_vscsi.c

Loading...

sys/powerpc/pseries/platform_chrp.c

Loading...

sys/powerpc/pseries/rtas_dev.c

Loading...

sys/powerpc/pseries/vdevice.c

Loading...

sys/powerpc/pseries/xics.c

Loading...

sys/powerpc/psim/ata_iobus.c

Loading...

sys/powerpc/psim/iobus.c

Loading...

sys/powerpc/psim/openpic_iobus.c

Loading...

sys/powerpc/psim/uart_iobus.c

Loading...