Add a USES=sbrk that sets BROKEN_aarch64 and BROKEN_risc64. This paves
the way for further deprecation of sbrk and will be extended to support
patching around various uses.
Details
Details
- Reviewers
- None
- Group Reviewers
portmgr - Commits
- R11:f6132c416155: Mk/Uses/sbrk.mk: centralize sbrk handling
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 60505 Build 57389: arc lint + arc unit
Event Timeline
Comment Actions
I'm sorry, I am not quite sure I understand what this is for.
Could you add a small documentation at the top of the file explaining exactly why this is needed, and in which cases one should add USES=sbrk?
Also, maybe in the ignore message, add that it does not take any argument.
Comment Actions
This centralizes a bunch of inconsistent BROKEN entries (see D47259) for aarch64 and riscv64 and makes it easy to search for consumers. I'm planning to further break sbrk support in 15 so there will need to be additional OSVERSION cases at which point it will all be a mess.
Further, I'm planning to add a library (not sure if it will be in ports or base) to access the compatibility symbols. When I do I plan to extend this code to support that library via additional ARGS.
Comment Actions
With your explanation and seeing the other review, I get it. It would have been nice to have all in the same review, it would have saved me some time trying to figure things out :-)
Please go ahead with both reviews.