sbrk.mk: centralize sbrk handling
ClosedPublic
Actions

Authored by brooks on Oct 22 2024, 8:44 PM.

Details

Reviewers

None

Group Reviewers

portmgr

Commits

R11:f6132c416155: Mk/Uses/sbrk.mk: centralize sbrk handling

Summary

Add a USES=sbrk that sets BROKEN_aarch64 and BROKEN_risc64. This paves
the way for further deprecation of sbrk and will be extended to support
patching around various uses.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 60506
Build 57390: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Oct 22 2024, 8:44 PM

brooks created this revision.

Harbormaster completed remote builds in B60166: Diff 145372.Oct 22 2024, 8:44 PM

brooks added a child revision: D47259: */*: use USES=sbrk.Oct 22 2024, 8:46 PM

I'm sorry, I am not quite sure I understand what this is for.
Could you add a small documentation at the top of the file explaining exactly why this is needed, and in which cases one should add USES=sbrk?
Also, maybe in the ignore message, add that it does not take any argument.

Improve comments

Harbormaster completed remote builds in B60505: Diff 146326.Tue, Nov 12, 4:54 PM

Be more clear that arguments are not (yet) allowed

Harbormaster completed remote builds in B60506: Diff 146327.Tue, Nov 12, 4:56 PM

In D47258#1083446, @mat wrote:

I'm sorry, I am not quite sure I understand what this is for.

This centralizes a bunch of inconsistent BROKEN entries (see D47259) for aarch64 and riscv64 and makes it easy to search for consumers. I'm planning to further break sbrk support in 15 so there will need to be additional OSVERSION cases at which point it will all be a mess.

Further, I'm planning to add a library (not sure if it will be in ports or base) to access the compatibility symbols. When I do I plan to extend this code to support that library via additional ARGS.

With your explanation and seeing the other review, I get it. It would have been nice to have all in the same review, it would have saved me some time trying to figure things out :-)
Please go ahead with both reviews.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Nov 19, 5:31 PM

Closed by commit R11:f6132c416155: Mk/Uses/sbrk.mk: centralize sbrk handling (authored by brooks). · Explain Why

This revision was automatically updated to reflect the committed changes.

brooks mentioned this in R11:6b7215ed5652: */*: use USES=sbrk.

brooks added a commit: R11:f6132c416155: Mk/Uses/sbrk.mk: centralize sbrk handling.