fwget: add -N to only show each package to be installed one by line
ClosedPublic
Actions

Authored by bz on Nov 5 2024, 12:05 AM.

Details

Reviewers

manu
bapt

Commits

rGdc647e4df990: fwget: add -q for quiet output
rG814a49d65ace: fwget: add -q for quiet output
rG1eb3f15c149b: fwget: add -q for quiet output

Summary

pkg-install(8) currently has no option to allow skipping unavail
packages but it will just fail.
We would realy want to try to install as much firmware as found and
possible from the installer.
We work around this by doing one firmware package at a time.
For that it is highly helpful to be able to query (or possibly re-query)
all outstanding fimrware packages in an easily parseable way.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 60389
Build 57273: arc lint + arc unit

Event Timeline

bz created this revision.Nov 5 2024, 12:05 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 5 2024, 12:05 AM

bz requested review of this revision.Nov 5 2024, 12:05 AM

Harbormaster completed remote builds in B60389: Diff 146016.Nov 5 2024, 12:05 AM

Maybe it would be better to add a -q (quiet mode) as other tools often have ?
so -nq would behave like your -N but we could use -q for other futur things.

This revision now requires changes to proceed.Nov 5 2024, 7:11 AM

What would you do with -q in the non-'-n' case? Also not print the echos in line (old/new) 115/131 and 120/136 or just leave as-is for now?

In D47445#1082183, @bz wrote:

What would you do with -q in the non-'-n' case? Also not print the echos in line (old/new) 115/131 and 120/136 or just leave as-is for now?

Yeah I guess so, usually -q doesn't print anything not intended to be a result.

@manu I tried and also switched to getopts.

fwget: add -q for quiet output

Introduce -q to quieten other output (unless -v is also given).

pkg-install(8) currently has no option to allow skipping unavail
packages but it will just fail.
We would realy want to try to install as much firmware found as
possible from the installer.
Work around this by doing one firmware package at a time.
For that it is highly helpful to be able to query (or possibly re-query)
all outstanding fimrware packages.
-q together with -n only shows each package to be installed one by line.

While here switch to getopts so -qn works and not just -q -n.

Harbormaster completed remote builds in B60426: Diff 146103.Nov 6 2024, 7:00 PM

bz planned changes to this revision.Nov 6 2024, 9:12 PM

bz added inline comments.