Paths

Table of Contentst

Differential D47255

x86/iommu/amd_reg.h: AMD IOMMU registers definitions
ClosedPublic
Actions

Authored by kib on Oct 22 2024, 8:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 9, 5:18 AM

	Unknown Object (File)
	Wed, Dec 4, 7:58 AM

	Unknown Object (File)
	Tue, Dec 3, 11:48 AM

	Unknown Object (File)
	Sun, Dec 1, 4:50 AM

	Unknown Object (File)
	Mon, Nov 25, 7:17 AM

	Unknown Object (File)
	Sun, Nov 24, 5:52 PM

	Unknown Object (File)
	Sat, Nov 16, 12:40 PM

	Unknown Object (File)
	Fri, Nov 15, 3:02 PM

View All 17 Files

Subscribers

Details

Reviewers

Commits

rG0a9bec17447c: x86/iommu/amd_reg.h: AMD IOMMU registers definitions

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 22 2024, 8:21 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 22 2024, 8:21 PM

kib requested review of this revision.Oct 22 2024, 8:21 PM

kib added a child revision: D47256: AMD IOMMU driver.

emaste added inline comments.Oct 27 2024, 5:23 PM

sys/x86/iommu/amd_reg.h
306–307	These are 16 bits are they not?
687	there's a reserved bit missing between vnr and vevent?

Fix several mistakes in re-typing

I've now looked through all the structs except amdiommu_cmd_generic and amdiommu_event_generic. I've only done a spot-check of the #defines, did not find any issues yet.

sys/x86/iommu/amd_reg.h
394	missing reserved bits between dest and vector?
638	is there missing padding before op here? also maybe I'm looking at a spec with a typo as it suggests op is 5 bits for reset_vmmio

kib marked an inline comment as done.Oct 28 2024, 1:07 AM

kib added inline comments.

sys/x86/iommu/amd_reg.h
394	This is from fig. 15 (table 20) on page 89, rev. 3.09. Can you point out the bits numbers for the reserved field you mean there?
638	It is op and rsrv2 which should be swapped.

emaste added inline comments.Oct 28 2024, 1:22 AM

sys/x86/iommu/amd_reg.h
394	Hmm, I guess I was looking at a vapic case somehow

I looked over the structs and spot-checked some #defines.

This revision is now accepted and ready to land.Nov 1 2024, 2:33 PM

Closed by commit rG0a9bec17447c: x86/iommu/amd_reg.h: AMD IOMMU registers definitions (authored by kib). · Explain WhyNov 2 2024, 11:47 PM

This revision was automatically updated to reflect the committed changes.

kib marked an inline comment as done.

kib added a commit: rG0a9bec17447c: x86/iommu/amd_reg.h: AMD IOMMU registers definitions.

Revision Contents
Changeset List

Path

Size

sys/

x86/

iommu/

746 lines

Diff 145909

sys/x86/iommu/amd_reg.h

Loading...