Page MenuHomeFreeBSD

x86/iommu/amd_reg.h: AMD IOMMU registers definitions
ClosedPublic

Authored by kib on Oct 22 2024, 8:21 PM.
Tags
None
Referenced Files
F104094520: D47255.diff
Tue, Dec 3, 11:48 AM
Unknown Object (File)
Sun, Dec 1, 4:50 AM
Unknown Object (File)
Mon, Nov 25, 7:17 AM
Unknown Object (File)
Sun, Nov 24, 5:52 PM
Unknown Object (File)
Sat, Nov 16, 12:40 PM
Unknown Object (File)
Fri, Nov 15, 3:02 PM
Unknown Object (File)
Wed, Nov 6, 9:58 PM
Unknown Object (File)
Wed, Nov 6, 9:58 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Oct 22 2024, 8:21 PM
kib added a child revision: D47256: AMD IOMMU driver.
sys/x86/iommu/amd_reg.h
306–307

These are 16 bits are they not?

687

there's a reserved bit missing between vnr and vevent?

kib marked 2 inline comments as done.

Fix several mistakes in re-typing

I've now looked through all the structs except amdiommu_cmd_generic and amdiommu_event_generic. I've only done a spot-check of the #defines, did not find any issues yet.

sys/x86/iommu/amd_reg.h
393

missing reserved bits between dest and vector?

637

is there missing padding before op here?

also maybe I'm looking at a spec with a typo as it suggests op is 5 bits for reset_vmmio

kib marked an inline comment as done.Oct 28 2024, 1:07 AM
kib added inline comments.
sys/x86/iommu/amd_reg.h
393

This is from fig. 15 (table 20) on page 89, rev. 3.09.

Can you point out the bits numbers for the reserved field you mean there?

637

It is op and rsrv2 which should be swapped.

sys/x86/iommu/amd_reg.h
393

Hmm, I guess I was looking at a vapic case somehow

I looked over the structs and spot-checked some #defines.

This revision is now accepted and ready to land.Nov 1 2024, 2:33 PM
This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.