Page MenuHomeFreeBSD
Differential D47316

sockstat: Add a -f option to show FIB numbers of sockets
ClosedPublic
Actions

Authored by markj on Oct 28 2024, 5:04 PM.
Tags
None
Referenced Files
F167995966: D47316.diff
Tue, Aug 25, 8:08 PM
F167956530: D47316.id145549.diff
Tue, Aug 25, 3:10 PM
F167936094: D47316.id.diff
Tue, Aug 25, 12:34 PM
Unknown Object (File)
Fri, Aug 21, 10:55 PM
Unknown Object (File)
Tue, Aug 18, 3:17 PM
Unknown Object (File)
Sun, Aug 16, 7:18 PM
Unknown Object (File)
Fri, Aug 14, 7:06 PM
Unknown Object (File)
Thu, Aug 13, 9:09 PM
View All 91 Files
Subscribers
imp
zlei

Details

Reviewers
zlei
Group Reviewers
network
Commits
rG7f0981f8efeb: sockstat: Add a -f option to show FIB numbers of sockets
rGa471d2b401c9: sockstat: Add a -f option to show FIB numbers of sockets
Summary

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60226
Build 57110: arc lint + arc unit

Event Timeline

markj created this revision.Oct 28 2024, 5:04 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 28 2024, 5:04 PM
markj requested review of this revision.Oct 28 2024, 5:04 PM
markj added a parent revision: D47315: socket: Export the FIB number of sockets.
Harbormaster completed remote builds in B60226: Diff 145549.Oct 28 2024, 5:04 PM
zlei accepted this revision as: zlei.Nov 1 2024, 7:14 AM
zlei added a subscriber: zlei.
zlei added inline comments.
usr.bin/sockstat/sockstat.c
1342

By default the GENERIC kernel limits the max number of fibs to 65535, See sys/net/route/route_var.h:

#define	RT_MAXFIBS	UINT16_MAX

So 6 chars width should be sufficient enough. But it would be better if you bother to explain this magic number :)

This revision is now accepted and ready to land.Nov 1 2024, 7:14 AM
markj marked an inline comment as done.Nov 1 2024, 1:08 PM
Closed by commit rGa471d2b401c9: sockstat: Add a -f option to show FIB numbers of sockets (authored by markj). · Explain WhyNov 4 2024, 2:57 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGa471d2b401c9: sockstat: Add a -f option to show FIB numbers of sockets.
markj added a commit: rG7f0981f8efeb: sockstat: Add a -f option to show FIB numbers of sockets.Nov 11 2024, 2:09 PM

Revision Contents
Changeset List

PathSize
usr.bin/
sockstat/
7 lines
21 lines

Diff 145549

View Options

usr.bin/sockstat/sockstat.1

Loading...
View Options

usr.bin/sockstat/sockstat.c

Loading...