Page MenuHomeFreeBSD
Differential D47195

sound: Call DSP_REGISTERED before PCM_DETACHING
ClosedPublic
Actions

Authored by christos on Oct 19 2024, 4:01 PM.
Tags
None
Referenced Files
F174215722: D47195.diff
Thu, Oct 1, 10:34 AM
F174181865: D47195.id145156.diff
Thu, Oct 1, 4:58 AM
Unknown Object (File)
Tue, Sep 22, 12:19 AM
Unknown Object (File)
Mon, Sep 21, 12:05 AM
Unknown Object (File)
Sat, Sep 19, 4:34 AM
Unknown Object (File)
Sat, Sep 19, 2:36 AM
Unknown Object (File)
Sat, Sep 19, 2:33 AM
Unknown Object (File)
Sat, Sep 19, 2:32 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGace5484e48c9: sound: Call DSP_REGISTERED before PCM_DETACHING
rG9693241188aa: sound: Call DSP_REGISTERED before PCM_DETACHING
Summary

DSP_REGISTERED first checks if the softc is not null, through
PCM_REGISTERED, which in turn calls PCM_ALIVE, whereas PCM_DETACHING
accesses the softc flags directly.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60089
Build 56973: arc lint + arc unit

Event Timeline

christos created this revision.Oct 19 2024, 4:01 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 19 2024, 4:01 PM
christos requested review of this revision.Oct 19 2024, 4:01 PM
Harbormaster completed remote builds in B60089: Diff 145156.Oct 19 2024, 4:01 PM
christos updated this revision to Diff 145157.Oct 19 2024, 4:01 PM

Use DSP_REGISTERED in dsp_close() as well.

Harbormaster completed remote builds in B60090: Diff 145157.Oct 19 2024, 4:01 PM
dev_submerge.ch added inline comments.Oct 20 2024, 8:00 PM
sys/dev/sound/pcm/dsp.c
304

I suppose it doesn't matter, but is the change from PCM_REGISTERED to DSP_REGISTERED intentional?

christos added inline comments.Oct 20 2024, 8:09 PM
sys/dev/sound/pcm/dsp.c
304

DSP_REGISTERED includes more checks, so I think it's better to use it and follow the same scheme as in the other functions.

markj accepted this revision.Oct 21 2024, 2:15 PM
This revision is now accepted and ready to land.Oct 21 2024, 2:15 PM
dev_submerge.ch accepted this revision.Oct 22 2024, 11:28 AM
emaste accepted this revision.Oct 22 2024, 2:33 PM
Closed by commit rG9693241188aa: sound: Call DSP_REGISTERED before PCM_DETACHING (authored by christos). · Explain WhyOct 24 2024, 11:37 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG9693241188aa: sound: Call DSP_REGISTERED before PCM_DETACHING.
christos added a commit: rGace5484e48c9: sound: Call DSP_REGISTERED before PCM_DETACHING.Oct 27 2024, 4:33 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
10 lines

Diff 145156

View Options

sys/dev/sound/pcm/dsp.c

Loading...