Page MenuHomeFreeBSD

sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()
ClosedPublic

Authored by christos on Sep 28 2024, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 14, 10:59 PM
Unknown Object (File)
Tue, Jul 14, 1:48 AM
Unknown Object (File)
Tue, Jul 14, 1:21 AM
Unknown Object (File)
Mon, Jul 13, 8:36 PM
Unknown Object (File)
Jun 15 2026, 5:46 AM
Unknown Object (File)
Jun 6 2026, 2:26 AM
Unknown Object (File)
May 6 2026, 2:07 AM
Unknown Object (File)
Apr 30 2026, 7:23 PM
Subscribers

Details

Summary

feeder_rate_min functions as the lower boundary.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/sound/pcm/vchan.c
511

We could just as well use RANGE() to fit the speed into the acceptable range, instead of returning an error.

dev_submerge.ch added inline comments.
sys/dev/sound/pcm/vchan.c
511

I'd prefer the EINVAL return here. The values close to feeder_rate_min and feeder_rate_max are unrealistic and never used in practice, going out of bounds here is almost certainly a user error.

This revision is now accepted and ready to land.Sep 29 2024, 3:08 PM