Page MenuHomeFreeBSD
Differential D41428

nfsstat: Complete libxo transition.
ClosedPublic
Actions

Authored by yanhaowang on Aug 11 2023, 1:45 PM.
Tags
None
Referenced Files
F162897450: D41428.id.diff
Sat, Jul 18, 3:00 AM
F162888383: D41428.diff
Sat, Jul 18, 1:01 AM
Unknown Object (File)
Sat, Jul 11, 2:12 PM
Unknown Object (File)
Sat, Jul 11, 2:12 PM
Unknown Object (File)
Tue, Jul 7, 2:10 AM
Unknown Object (File)
Tue, Jul 7, 2:08 AM
Unknown Object (File)
Tue, Jul 7, 1:25 AM
Unknown Object (File)
Mon, Jul 6, 7:18 PM
View All Files
Subscribers
imp
patmaddox

Details

Reviewers
lwhsu
des
Commits
rGb698093da430: nfsstat(1): Complete libxo transition

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yanhaowang created this revision.Aug 11 2023, 1:45 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 11 2023, 1:45 PM
yanhaowang requested review of this revision.Aug 11 2023, 1:45 PM
Harbormaster completed remote builds in B53050: Diff 125879.Aug 11 2023, 1:45 PM
yanhaowang added a reviewer: des.Aug 11 2023, 1:46 PM
lwhsu added inline comments.Aug 11 2023, 7:44 PM
usr.bin/nfsstat/nfsstat.c
86

Please avoid contiguous blank lines.

yanhaowang updated this revision to Diff 125895.Aug 12 2023, 1:29 AM

Remove unnecessary space.

Harbormaster completed remote builds in B53058: Diff 125895.Aug 12 2023, 1:29 AM
yanhaowang marked an inline comment as done.Aug 12 2023, 1:30 AM
des requested changes to this revision.Aug 17 2023, 4:02 PM
des added inline comments.
usr.bin/nfsstat/nfsstat.c
507–508

This should be xo_error().

This revision now requires changes to proceed.Aug 17 2023, 4:02 PM
yanhaowang added inline comments.Aug 19 2023, 8:14 AM
usr.bin/nfsstat/nfsstat.c
507–508

Maybe use xo_err(1, "usage: nfsstat [-cdemszW] [-w wait]\n"); to replace the fprintf and exit function?

yanhaowang updated this revision to Diff 126224.Aug 19 2023, 8:36 AM
This comment was removed by yanhaowang.
Harbormaster completed remote builds in B53172: Diff 126224.Aug 19 2023, 8:36 AM
yanhaowang marked an inline comment as done.Aug 19 2023, 8:42 AM
yanhaowang added inline comments.
usr.bin/nfsstat/nfsstat.c
507–508

Ignore this, xo_err can't replace fprintf.

yanhaowang updated this revision to Diff 126225.EditedAug 19 2023, 8:46 AM
  • Use xo_error instead of fprintf.
  • Decide using 1 and 0 instead of EXIT_FAILURE and EXIT_SUCESS.
Harbormaster completed remote builds in B53173: Diff 126225.Aug 19 2023, 8:46 AM
des accepted this revision.Aug 19 2023, 1:34 PM
This revision is now accepted and ready to land.Aug 19 2023, 1:34 PM
patmaddox added a subscriber: patmaddox.Oct 19 2023, 9:46 PM
Closed by commit rGb698093da430: nfsstat(1): Complete libxo transition (authored by yanhaowang, committed by lwhsu). · Explain WhyOct 12 2024, 6:30 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: rGb698093da430: nfsstat(1): Complete libxo transition.

Revision Contents
Changeset List

PathSize
usr.bin/
nfsstat/
13 lines

Diff 144739

View Options

usr.bin/nfsstat/nfsstat.c

Loading...