Details
Details
- Reviewers
lwhsu des - Commits
- rGb698093da430: nfsstat(1): Complete libxo transition
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 53173 Build 50064: arc lint + arc unit
Event Timeline
| usr.bin/nfsstat/nfsstat.c | ||
|---|---|---|
| 100 | Please avoid contiguous blank lines. | |
| usr.bin/nfsstat/nfsstat.c | ||
|---|---|---|
| 515–516 | This should be xo_error(). | |
| usr.bin/nfsstat/nfsstat.c | ||
|---|---|---|
| 515–516 | Maybe use xo_err(1, "usage: nfsstat [-cdemszW] [-w wait]\n"); to replace the fprintf and exit function? | |
This comment was removed by yanhaowang.
| usr.bin/nfsstat/nfsstat.c | ||
|---|---|---|
| 515–516 | Ignore this, xo_err can't replace fprintf. | |
Comment Actions
- Use xo_error instead of fprintf.
- Decide using 1 and 0 instead of EXIT_FAILURE and EXIT_SUCESS.