Page MenuHomeFreeBSD
Differential D47019

cmp: Style and type issues.
ClosedPublic
Actions

Authored by des on Oct 8 2024, 10:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 5:39 PM
Unknown Object (File)
Feb 17 2025, 4:39 AM
Unknown Object (File)
Feb 16 2025, 9:43 AM
Unknown Object (File)
Feb 16 2025, 5:53 AM
Unknown Object (File)
Feb 3 2025, 1:45 PM
Unknown Object (File)
Jan 30 2025, 2:20 PM
Unknown Object (File)
Jan 24 2025, 2:45 PM
Unknown Object (File)
Jan 24 2025, 2:31 PM
View All 32 Files
Subscribers
imp

Details

Reviewers
markj
0mp
Group Reviewers
Klara
Commits
rG11b0b75a9fba: cmp: Style and type issues.
rG02a8a4e4eb25: cmp: Style and type issues.
rGd350e8d795d5: cmp: Style and type issues.
Summary

MFC after: 3 days
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59854
Build 56739: arc lint + arc unit

Event Timeline

des created this revision.Oct 8 2024, 10:02 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 8 2024, 10:02 PM
des requested review of this revision.Oct 8 2024, 10:02 PM
Harbormaster completed remote builds in B59854: Diff 144504.Oct 8 2024, 10:02 PM
des added a child revision: D47020: cmp: Check the status of stdout..Oct 8 2024, 10:02 PM
markj accepted this revision as: markj.Oct 8 2024, 11:02 PM
This revision is now accepted and ready to land.Oct 8 2024, 11:02 PM
0mp accepted this revision.Oct 9 2024, 9:50 AM
des updated this revision to Diff 144520.Oct 9 2024, 9:58 AM

also tidy some tests

This revision now requires review to proceed.Oct 9 2024, 9:58 AM
Harbormaster completed remote builds in B59860: Diff 144520.Oct 9 2024, 9:58 AM
markj accepted this revision as: markj.Oct 9 2024, 11:23 AM
This revision is now accepted and ready to land.Oct 9 2024, 11:23 AM
Closed by commit rGd350e8d795d5: cmp: Style and type issues. (authored by des). · Explain WhyOct 9 2024, 12:12 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGd350e8d795d5: cmp: Style and type issues..
des added a commit: rG02a8a4e4eb25: cmp: Style and type issues..Oct 15 2024, 6:30 AM
des added a commit: rG11b0b75a9fba: cmp: Style and type issues..

Revision Contents
Changeset List

PathSize
usr.bin/
cmp/
4 lines
4 lines
1 line
1 line

Diff 144504

View Options

usr.bin/cmp/cmp.c

Show All 37 Lines
/* Local stuff. */ /* Local stuff. */
#include "patchlevel.h" #include "patchlevel.h"
#include "tcpd.h" #include "tcpd.h"
int allow_severity = SEVERITY; /* run-time adjustable */ int allow_severity = SEVERITY; /* run-time adjustable */
int deny_severity = LOG_WARNING; /* ditto */ int deny_severity = LOG_WARNING; /* ditto */
main(argc, argv) main(int argc, char **argv)
int argc;
char **argv;
{ {
struct request_info request; struct request_info request;
char path[MAXPATHNAMELEN]; char path[MAXPATHNAMELEN];
/* Attempt to prevent the creation of world-writable files. */ /* Attempt to prevent the creation of world-writable files. */
#ifdef DAEMON_UMASK #ifdef DAEMON_UMASK
umask(DAEMON_UMASK); umask(DAEMON_UMASK);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines
View Options

usr.bin/cmp/link.c

Show All 37 Lines
/* Local stuff. */ /* Local stuff. */
#include "patchlevel.h" #include "patchlevel.h"
#include "tcpd.h" #include "tcpd.h"
int allow_severity = SEVERITY; /* run-time adjustable */ int allow_severity = SEVERITY; /* run-time adjustable */
int deny_severity = LOG_WARNING; /* ditto */ int deny_severity = LOG_WARNING; /* ditto */
main(argc, argv) main(int argc, char **argv)
int argc;
char **argv;
{ {
struct request_info request; struct request_info request;
char path[MAXPATHNAMELEN]; char path[MAXPATHNAMELEN];
/* Attempt to prevent the creation of world-writable files. */ /* Attempt to prevent the creation of world-writable files. */
#ifdef DAEMON_UMASK #ifdef DAEMON_UMASK
umask(DAEMON_UMASK); umask(DAEMON_UMASK);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines
View Options

usr.bin/cmp/regular.c

Show All 37 Lines
/* Local stuff. */ /* Local stuff. */
#include "patchlevel.h" #include "patchlevel.h"
#include "tcpd.h" #include "tcpd.h"
int allow_severity = SEVERITY; /* run-time adjustable */ int allow_severity = SEVERITY; /* run-time adjustable */
int deny_severity = LOG_WARNING; /* ditto */ int deny_severity = LOG_WARNING; /* ditto */
main(argc, argv) main(int argc, char **argv)
int argc;
char **argv;
{ {
struct request_info request; struct request_info request;
char path[MAXPATHNAMELEN]; char path[MAXPATHNAMELEN];
/* Attempt to prevent the creation of world-writable files. */ /* Attempt to prevent the creation of world-writable files. */
#ifdef DAEMON_UMASK #ifdef DAEMON_UMASK
umask(DAEMON_UMASK); umask(DAEMON_UMASK);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines
View Options

usr.bin/cmp/special.c

Show All 37 Lines
/* Local stuff. */ /* Local stuff. */
#include "patchlevel.h" #include "patchlevel.h"
#include "tcpd.h" #include "tcpd.h"
int allow_severity = SEVERITY; /* run-time adjustable */ int allow_severity = SEVERITY; /* run-time adjustable */
int deny_severity = LOG_WARNING; /* ditto */ int deny_severity = LOG_WARNING; /* ditto */
main(argc, argv) main(int argc, char **argv)
int argc;
char **argv;
{ {
struct request_info request; struct request_info request;
char path[MAXPATHNAMELEN]; char path[MAXPATHNAMELEN];
/* Attempt to prevent the creation of world-writable files. */ /* Attempt to prevent the creation of world-writable files. */
#ifdef DAEMON_UMASK #ifdef DAEMON_UMASK
umask(DAEMON_UMASK); umask(DAEMON_UMASK);
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines