Page MenuHomeFreeBSD

[special] igor -Ry and some other rewording and fixes.
ClosedPublic

Authored by mat on Aug 20 2014, 3:08 PM.
Tags
None
Referenced Files
F82078628: D653.id1179.diff
Thu, Apr 25, 7:35 AM
Unknown Object (File)
Thu, Apr 18, 7:19 PM
Unknown Object (File)
Dec 19 2023, 7:33 PM
Unknown Object (File)
Dec 11 2023, 1:02 AM
Unknown Object (File)
Nov 15 2023, 8:52 AM
Unknown Object (File)
Nov 11 2023, 7:36 PM
Unknown Object (File)
Nov 11 2023, 5:20 AM
Unknown Object (File)
Nov 7 2023, 1:54 AM
Subscribers

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mat retitled this revision from to [special] igor -Ry and some other rewording and fixes..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
wblock added inline comments.
en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
12–13

<para>This section explains the most common things to consider when creating a port.</para>

44

s/mostly/mostly be/

69

This one actually needs "should". It's a recommendation on when to create directories.

74

s/has to be/is/

222

s/upstream/the upstream/

250

setting <varname>USE_LDCONFIG</varname> to a list of

252

s/example/example,/

254

<filename>PREFIX/lib/bar</filename>,

320–321

s/has to/must/

323

s/in to/into/

327

s/cannot not be/cannot be/

374–376

<varname>RESTRICTED</varname>, since the latter variable

500–501

s/else/other/

503

s/Same/The same/

668

s/if port/if the port/

882

s/^/an /

948

Break sentence at NLS. Also use <acronym> tags on NLS.

954

s/on//

1005–1006

In high complexity cases, more advanced techniques

1006

may be needed, such as

1058–1059

s/like/as/

1335

I think this is one where "should" is correct.

2043

s/so that/for/

2072–2073

When set, add the selected JDK port to the build dependencies.

2079–2080

When set, add the selected JDK port to the run dependencies.

2085–2086

When set, add the selected JDK port to the extract dependencies.

2109–2110

Should this have the single quotes?

2253–2255

"forecited" is a word, but a rare one. "previously listed variables" is better.

2281

s/is/are/

2338

s/use/uses/

2370–2371

s/the//

2371

s/must/is/

2572

mygroup</literal> if the port needs different values. This

2573

allows the user to override them easily.</para>

2576

s/the/a/

2715

s/must make sure to/must/

2965–2966

Do not redefine these variables in the port.

3156

s/entries using/entries for/

3588

s/default define/default, define/

3596–3597

s/version define/version, define/

4360

This is a recommendation:

earlier, all ports scripts should use</para>

4403–4404

s/have/have a/

4403–4404

s/If so that/If so, that/

4488

"Should" is a recommendation here, and correct.

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
1335

I don't think so, if it has those files, they must be listed in the plist, and be installed in the directory below. Maybe i should have used "must" and not "have to" ?

2072–2073

Should I add <acronym> around JDK too ? should I do this everywhere ?

2109–2110

nope.

Update with comments from wblock

en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
1335

Yes, "must" is more definite than "have to".

2072–2073

Yes. Anything that is an acronym should have <acronym> tags.

wblock added a reviewer: wblock.

Please build-test, then commit.

This revision is now accepted and ready to land.Sep 15 2014, 9:39 PM
mat updated this revision to Diff 1638.

Closed by commit rD45616 (authored by @mat).