in case of building with WITHOUT_ISCSI, we don’t want tests/sys/cam/ctl/ too.
Details
Details
- Reviewers
jhb asomers - Group Reviewers
tests cam - Commits
- rG215fd38e2915: ctl: skip the test if ctladm is missing (WITHOUT_ISCSI)
Before:
Building with WITHOUT_ISCSI, all tests/sys/cam/ctl/ are failing because ctladm missing.
After:
No more tests/sys/cam/ctl… so no more failure.
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Technically, ctl can be used without iscsi, so I think that MK knob is named wrong. But that's beyond the scope of this PR. I think that this change is OK. Note that another way to fix the same problem would be add ctladm to the list of require.progs in each test case within that directory. But your method requires less code.
Comment Actions
I have a slight preference for require.prog since the counts are better aligne. Also, that lets people install the dist tests on their maybe customized systems for QA. I'll likely need to skip these for bsd-user too, but that's also beyond the scope. But I'm not insisting because this solves the immediate need
Comment Actions
I will update this patch it and use the require.progs, because it is already used so I just need to add ctladm.
Comment Actions
New version using requiered_progs.
But anyway which port should insall all the missing sg_* binaries ? I don’t find instruction about them.
Because right now they are ignored:
https://ci.freebsd.org/job/FreeBSD-main-amd64-test/lastCompletedBuild/testReport/sys.cam.ctl/prevent/allow/