Page MenuHomeFreeBSD

sound: Remove useless newspd check in sysctl_dev_pcm_vchanrate()
ClosedPublic

Authored by christos on Sep 28 2024, 3:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 7, 5:21 AM
Unknown Object (File)
Wed, Nov 26, 1:16 AM
Unknown Object (File)
Nov 18 2025, 10:16 AM
Unknown Object (File)
Nov 4 2025, 4:53 PM
Unknown Object (File)
Nov 4 2025, 4:47 PM
Unknown Object (File)
Nov 4 2025, 4:47 PM
Unknown Object (File)
Nov 4 2025, 4:43 PM
Unknown Object (File)
Nov 3 2025, 4:26 AM
Subscribers

Details

Summary

feeder_rate_min functions as the lower boundary.

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59644
Build 56531: arc lint + arc unit

Event Timeline

sys/dev/sound/pcm/vchan.c
511

We could just as well use RANGE() to fit the speed into the acceptable range, instead of returning an error.

dev_submerge.ch added inline comments.
sys/dev/sound/pcm/vchan.c
511

I'd prefer the EINVAL return here. The values close to feeder_rate_min and feeder_rate_max are unrealistic and never used in practice, going out of bounds here is almost certainly a user error.

This revision is now accepted and ready to land.Sep 29 2024, 3:08 PM