sound: Simplify vchan_create() error paths
ClosedPublic
Actions

Authored by christos on Sep 28 2024, 3:12 PM.

Details

Reviewers

markj
emaste
dev_submerge.ch

Commits

rGbf058bde2bca: sound: Simplify vchan_create() error paths
rG3cab66d12d43: sound: Simplify vchan_create() error paths

Summary

Instead of checking the value of "ret" multiple times, just set a goto
label and jump there immediately in case of an error.

While here, remove a redundant assignment to "d".

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 59643
Build 56530: arc lint + arc unit

Event Timeline

christos created this revision.Sep 28 2024, 3:12 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2024, 3:12 PM

christos requested review of this revision.Sep 28 2024, 3:12 PM

Harbormaster completed remote builds in B59643: Diff 143866.Sep 28 2024, 3:12 PM

dev_submerge.ch accepted this revision.Sep 29 2024, 2:47 PM

This revision is now accepted and ready to land.Sep 29 2024, 2:47 PM

markj accepted this revision.Sep 30 2024, 9:04 AM

Maybe also make save a bool while you're here?

Closed by commit rG3cab66d12d43: sound: Simplify vchan_create() error paths (authored by christos). · Explain WhyOct 18 2024, 8:45 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG3cab66d12d43: sound: Simplify vchan_create() error paths.

christos added a commit: rGbf058bde2bca: sound: Simplify vchan_create() error paths.Oct 20 2024, 11:22 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

vchan.c

69 lines

Diff 143866

View Options

sound: Simplify vchan_create() error pathsClosedPublicActions