Check for negative lengths in m_pulldown
Needs ReviewPublic
Actions

Authored by cturt_hardenedbsd.org on Mar 16 2016, 8:01 PM.

Tags

None

Referenced Files

	F166576102: D5660.id.diff
	Fri, Aug 14, 4:09 PM

	Unknown Object (File)
	Tue, Aug 11, 11:49 PM

	Unknown Object (File)
	Tue, Aug 11, 11:38 PM

	Unknown Object (File)
	Mon, Aug 3, 8:26 AM

	Unknown Object (File)
	Sun, Aug 2, 1:55 AM

	Unknown Object (File)
	Sat, Aug 1, 7:58 AM

	Unknown Object (File)
	Fri, Jul 31, 5:34 PM

	Unknown Object (File)
	Jul 11 2026, 4:41 PM

Subscribers

Contributor Reviews (src)

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

cturt_hardenedbsd.org updated this revision to Diff 14374.Mar 16 2016, 8:01 PM

cturt_hardenedbsd.org retitled this revision from to Check for negative lengths in m_pulldown.

cturt_hardenedbsd.org updated this object.

cturt_hardenedbsd.org edited the test plan for this revision. (Show Details)

cturt_hardenedbsd.org set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMar 16 2016, 8:01 PM

lattera-gmail.com added a subscriber: lattera-gmail.com.Mar 16 2016, 8:02 PM

Could you please reupload the patch with bigger context? git diff -U9999 for example?

And add adrian@, gnn@ and glebius@ as reviewer?

mmokhi added a subscriber: mmokhi.Mar 23 2016, 2:00 PM

Can you please be more informative about the change? What provokes it? To me negative len on input seems just an incorrect input and should be turned into KASSERT that len is positive and > 0.

Revision Contents
Changeset List

Path

Size

uipc_mbuf2.c

2 lines

Diff 14374

View Options

Check for negative lengths in m_pulldownNeeds ReviewPublicActions