boot/efi: Prefer nm to objdump
ClosedPublic
Actions

Authored by emaste on Mar 11 2016, 9:07 PM.

Details

Reviewers

imp
bdrewery

Commits

rS296769: boot/efi: Prefer nm to objdump

Summary

This gets us a step closer to building without binutils as we have an nm implementation from ELF Tool Chain.

Test Plan

apply patch, verify buildworld passes
add a call to a dummy undef function, verify buildworld fails

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste updated this revision to Diff 14250.Mar 11 2016, 9:07 PM

emaste retitled this revision from to boot/efi: Prefer nm to objdump.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added reviewers: imp, bdrewery.

rework test to avoid bare !

bdrewery accepted this revision.Mar 12 2016, 7:35 PM

bdrewery edited edge metadata.

This revision is now accepted and ready to land.Mar 12 2016, 7:35 PM

Wait it has an issue

This revision now requires changes to proceed.Mar 12 2016, 7:36 PM

sh -c 'set -e; true | false && exit 2;'; echo $?
when the && fails it still exits with an error
putting it in a if line fixes that

if ${NM} ${.ALLSRC} | grep ' U'; then exit 1; fi

In D5613#119986, @bdrewery wrote:

sh -c 'set -e; true | false && exit 2;'; echo $?
when the && fails it still exits with an error
putting it in a if line fixes that

if ${NM} ${.ALLSRC} | grep ' U'; then exit 1; fi

But exit won't work in make so use false instead.

Or rework it to use || which won't default fail

In D5613#119987, @bdrewery wrote:

In D5613#119986, @bdrewery wrote:

sh -c 'set -e; true | false && exit 2;'; echo $?
when the && fails it still exits with an error
putting it in a if line fixes that

if ${NM} ${.ALLSRC} | grep ' U'; then exit 1; fi

But exit won't work in make so use false instead.