Page MenuHomeFreeBSD

boot/efi: Prefer nm to objdump
ClosedPublic

Authored by emaste on Mar 11 2016, 9:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 10, 7:06 AM
Unknown Object (File)
Thu, Jun 6, 10:54 PM
Unknown Object (File)
Thu, Jun 6, 6:27 PM
Unknown Object (File)
May 15 2024, 1:22 PM
Unknown Object (File)
Apr 24 2024, 4:43 AM
Unknown Object (File)
Apr 24 2024, 4:07 AM
Unknown Object (File)
Apr 24 2024, 3:57 AM
Unknown Object (File)
Feb 13 2024, 5:11 AM
Subscribers
None

Details

Summary

This gets us a step closer to building without binutils as we have an nm implementation from ELF Tool Chain.

Test Plan
  • apply patch, verify buildworld passes
  • add a call to a dummy undef function, verify buildworld fails

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to boot/efi: Prefer nm to objdump.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: imp, bdrewery.

rework test to avoid bare !

bdrewery edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2016, 7:35 PM
bdrewery edited edge metadata.

Wait it has an issue

This revision now requires changes to proceed.Mar 12 2016, 7:36 PM

sh -c 'set -e; true | false && exit 2;'; echo $?
when the && fails it still exits with an error
putting it in a if line fixes that

if ${NM} ${.ALLSRC} | grep ' U'; then exit 1; fi

sh -c 'set -e; true | false && exit 2;'; echo $?
when the && fails it still exits with an error
putting it in a if line fixes that

if ${NM} ${.ALLSRC} | grep ' U'; then exit 1; fi

But exit won't work in make so use false instead.

Or rework it to use || which won't default fail

sh -c 'set -e; true | false && exit 2;'; echo $?
when the && fails it still exits with an error
putting it in a if line fixes that

if ${NM} ${.ALLSRC} | grep ' U'; then exit 1; fi

But exit won't work in make so use false instead.

Sorry, exit is fine here. It's not as a bare command.

emaste edited edge metadata.

Update per @bdrewery's comment

bdrewery edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2016, 8:26 PM
This revision was automatically updated to reflect the committed changes.