Page MenuHomeFreeBSD
Differential D46399

lib/libc/aarch64/string: add optimized strpbrk & strsep implementations
ClosedPublic
Actions

Authored by getz on Aug 21 2024, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 6:55 PM
Unknown Object (File)
Mon, Nov 3, 6:05 PM
Unknown Object (File)
Sat, Nov 1, 6:49 AM
Unknown Object (File)
Tue, Oct 28, 8:07 AM
Unknown Object (File)
Mon, Oct 27, 11:29 PM
Unknown Object (File)
Mon, Oct 27, 3:41 PM
Unknown Object (File)
Mon, Oct 27, 8:48 AM
Unknown Object (File)
Mon, Oct 27, 8:25 AM
View All 99 Files
Subscribers
imp

Details

Reviewers
fuz
emaste
andrew
Commits
rG89b3872376cb: lib/libc/aarch64/string: add optimized strpbrk & strsep implementations
Summary

These are direct copies from the amd64 string functions using the
optimized strcspn from D46398

Test Plan

No regressions noticed

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59138
Build 56025: arc lint + arc unit

Event Timeline

getz created this revision.Aug 21 2024, 4:29 PM
Herald added a reviewer: andrew. · View Herald TranscriptAug 21 2024, 4:29 PM
Herald added a subscriber: imp. · View Herald Transcript
getz requested review of this revision.Aug 21 2024, 4:29 PM
Harbormaster completed remote builds in B59127: Diff 142312.Aug 21 2024, 4:29 PM
getz added a parent revision: D46398: lib/libc/aarch64/string: add strcspn optimized implementation.Aug 21 2024, 4:30 PM
fuz added a comment.Aug 21 2024, 10:00 PM

Ok.

lib/libc/aarch64/string/strsep.c
36
getz updated this revision to Diff 142338.Aug 22 2024, 8:34 AM
  • amd64 -> aarch64 :)
Harbormaster completed remote builds in B59138: Diff 142338.Aug 22 2024, 8:34 AM
andrew added a comment.Sep 22 2024, 6:17 PM

Could this be machine independent?

fuz added a comment.Sep 23 2024, 9:15 AM

@andrew If we don't have an assembly implementation for strcspn, it's generally faster to implement this function directly.

fuz accepted this revision.Nov 6 2024, 2:23 PM

exp-run says it's fine.

This revision is now accepted and ready to land.Nov 6 2024, 2:23 PM
Closed by commit rG89b3872376cb: lib/libc/aarch64/string: add optimized strpbrk & strsep implementations (authored by getz, committed by fuz). · Explain WhyJan 10 2025, 3:04 PM
This revision was automatically updated to reflect the committed changes.
fuz added a commit: rG89b3872376cb: lib/libc/aarch64/string: add optimized strpbrk & strsep implementations.

Revision Contents
Changeset List

PathSize
lib/
libc/
aarch64/
string/
3 lines
43 lines
57 lines

Diff 142338

View Options

lib/libc/aarch64/string/Makefile.inc

Loading...
View Options

lib/libc/aarch64/string/strpbrk.c

Loading...
View Options

lib/libc/aarch64/string/strsep.c

Loading...