Page MenuHomeFreeBSD

databases/percona56-server: update to 5.6.29-76.2, add TokuDB engine option
ClosedPublic

Authored by pservit_gmail.com on Mar 10 2016, 9:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 28, 11:11 AM
Unknown Object (File)
Thu, Mar 28, 10:16 AM
Unknown Object (File)
Jan 28 2024, 10:16 PM
Unknown Object (File)
Jan 27 2024, 12:18 PM
Unknown Object (File)
Jan 24 2024, 6:10 PM
Unknown Object (File)
Jan 21 2024, 7:55 PM
Unknown Object (File)
Dec 20 2023, 7:20 AM
Unknown Object (File)
Nov 13 2023, 1:27 PM
Subscribers

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2845
Build 2869: arc lint + arc unit

Event Timeline

pservit_gmail.com retitled this revision from to databases/percona56-server: update to 5.6.29-76.2, add TokuDB engine option.
pservit_gmail.com updated this object.
pservit_gmail.com edited the test plan for this revision. (Show Details)
pservit_gmail.com added a reviewer: flo.
pservit_gmail.com set the repository for this revision to rP FreeBSD ports repository.

Could you please use devel/arcanist to upload your patches ? Or at least, could you upload the result of svn diff --diff-cmd=diff -x -U9999 so that we can get context while doing the review ?

databases/percona56-server/Makefile
24

This should be named "extrapatch-tokudb" to be more consistent with the rest of the tree.

databases/percona56-server/Makefile
67–69

I think these should be set using helpers and sooner in the Makefile, for example:

TOKUDB_CMAKE_ON=      -DUSE_CTAGS=0
TOKUDB_VARS=          ONLY_FOR_ARCH=amd64
ONLY_FOR_ARCH_REASON= TokuDB engine does not compile on ${ARCH}

The ONLY_FOR_ARCH_REASON can be set regardless as it's a no-op if ONLY_FOR_ARCH is not defined.

(while there, you could convert the two options blocs just before to helpers too.)

databases/percona56-server/Makefile
27–31

Thinking about it, this is a "server" only option, maybe you should add:

OPTIONS_EXCLUDE=TOKUDB

To databases/percona56-client/Makefile, so that it's not available as an option there.

54

That's not needed any more. (Sorry, should have said earlier.)

Exclude TOKUDB option from client, fix client patch

This revision was automatically updated to reflect the committed changes.