databases/percona56-server: update to 5.6.29-76.2, add TokuDB engine option

[pservit_gmail.com]

fix $FreeBSD$

[mat]

Could you please use devel/arcanist to upload your patches ? Or at least, could you upload the result of svn diff --diff-cmd=diff -x -U9999 so that we can get context while doing the review ?

databases/percona56-server/Makefile

24 ↗

(On Diff #14221)

This should be named "extrapatch-tokudb" to be more consistent with the rest of the tree.

[pservit_gmail.com]

rename patch, use arcanist

[mat]

databases/percona56-server/Makefile

67–69 ↗

(On Diff #14222)

I think these should be set using helpers and sooner in the Makefile, for example:

TOKUDB_CMAKE_ON=      -DUSE_CTAGS=0
TOKUDB_VARS=          ONLY_FOR_ARCH=amd64
ONLY_FOR_ARCH_REASON= TokuDB engine does not compile on ${ARCH}

The ONLY_FOR_ARCH_REASON can be set regardless as it's a no-op if ONLY_FOR_ARCH is not defined.

(while there, you could convert the two options blocs just before to helpers too.)

[pservit_gmail.com]

use option helpers

[mat]

databases/percona56-server/Makefile

27–31 ↗

(On Diff #14223)

Thinking about it, this is a "server" only option, maybe you should add:

OPTIONS_EXCLUDE=TOKUDB

To databases/percona56-client/Makefile, so that it's not available as an option there.

60 ↗

(On Diff #14223)

That's not needed any more. (Sorry, should have said earlier.)

[pservit_gmail.com]

Exclude TOKUDB option from client, fix client patch