Details
Details
- Reviewers
flo - Commits
- rP413865: - update to 5.6.29-76.2
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Could you please use devel/arcanist to upload your patches ? Or at least, could you upload the result of svn diff --diff-cmd=diff -x -U9999 so that we can get context while doing the review ?
| databases/percona56-server/Makefile | ||
|---|---|---|
| 24 | This should be named "extrapatch-tokudb" to be more consistent with the rest of the tree. | |
| databases/percona56-server/Makefile | ||
|---|---|---|
| 67–69 | I think these should be set using helpers and sooner in the Makefile, for example: TOKUDB_CMAKE_ON= -DUSE_CTAGS=0
TOKUDB_VARS= ONLY_FOR_ARCH=amd64
ONLY_FOR_ARCH_REASON= TokuDB engine does not compile on ${ARCH}The ONLY_FOR_ARCH_REASON can be set regardless as it's a no-op if ONLY_FOR_ARCH is not defined. (while there, you could convert the two options blocs just before to helpers too.) | |