openssl: declare getrandom(2) before use
AbandonedPublic
Actions

Authored by brooks on Jul 26 2024, 4:31 PM.

Details

Reviewers

kevans
imp

Summary

Remove partial support for entropy by sysctl and include sys/random.h.

Fixes: 838b6caababb openssl: use getrandom(2) instead of probing for getentropy(2)

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 58864
Build 55751: arc lint + arc unit

Event Timeline

brooks created this revision.Jul 26 2024, 4:31 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 26 2024, 4:31 PM

brooks requested review of this revision.Jul 26 2024, 4:31 PM

Harbormaster completed remote builds in B58864: Diff 141446.Jul 26 2024, 4:31 PM

Without this GitHub CI fails with an error that getrandom is undeclared. I have no idea why that fails and other builds are fine.

I see the warning in my builds, but it keeps going...

This revision is now accepted and ready to land.Jul 26 2024, 5:34 PM

jhb has a similar patch here https://reviews.freebsd.org/D45995 and I had a similar fix upstream https://github.com/openssl/openssl/pull/24903/files but I've failed to get @bcran (or anyone in upstream OpenSSL) to weigh in on an appropriate solution for their part, so I guess just do it and I'll reconcile the differences later.

After review, I think D45995 is more correct so abandoning this one.

Revision Contents
Changeset List

Path

Size

crypto/

openssl/

providers/

implementations/

rands/

seeding/

rand_unix.c

6 lines

Diff 141446

View Options

crypto/openssl/providers/implementations/rands/seeding/rand_unix.c

openssl: declare getrandom(2) before useAbandonedPublicActions