Page MenuHomeFreeBSD
Differential D45898

sound: Add missing CHN_[UN]LOCKs in sndstat
ClosedPublic
Actions

Authored by christos on Jul 6 2024, 3:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 22, 5:57 PM
Unknown Object (File)
Wed, Aug 19, 7:53 AM
Unknown Object (File)
Sun, Aug 16, 5:28 AM
Unknown Object (File)
Sat, Aug 15, 10:51 AM
Unknown Object (File)
Thu, Aug 13, 5:34 PM
Unknown Object (File)
Tue, Aug 11, 2:11 AM
Unknown Object (File)
Thu, Aug 6, 9:59 PM
Unknown Object (File)
Thu, Aug 6, 1:20 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
Commits
rGfab137d23462: sound: Add missing CHN_[UN]LOCKs in sndstat
rGe850bd36dfda: sound: Add missing CHN_[UN]LOCKs in sndstat
Summary

For sndstat_build_sound4_nvlist(), if we have INVARIANTS or
SND_DIAGNOSTIC enabled, we will hit an lock assertion panic when we call
CHN_GETVOLUME(). Also lock the channel in the sndstat_prepare_pcm() loop
for good measure.

Fixes: bbca3a75bb41 ("sound: Include sound(4) channel information in sndstat nvlist")
Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58537
Build 55425: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
8 lines

Diff 140621

View Options

sys/dev/sound/pcm/sndstat.c

Loading...