Page MenuHomeFreeBSD

sound: Add min_rate and min_channels safety check in SNDCTL_AUDIOINFO
ClosedPublic

Authored by christos on Jul 5 2024, 2:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 6, 1:12 AM
Unknown Object (File)
Thu, Jun 5, 1:01 AM
Unknown Object (File)
Tue, Jun 3, 9:20 AM
Unknown Object (File)
Tue, Jun 3, 3:20 AM
Unknown Object (File)
Sun, May 18, 7:42 PM
Unknown Object (File)
Sat, May 17, 6:29 AM
Unknown Object (File)
Sun, May 11, 8:55 PM
Unknown Object (File)
Apr 29 2025, 1:43 AM
Subscribers

Details

Summary

If the channel list is empty, min_rate and min_channels will be INT_MAX.
Instead, assign them to 0, like we do in sndstat_get_caps().

Sponsored by: The FreeBSD Foundation
MFC after: 2 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 58506
Build 55394: arc lint + arc unit

Event Timeline

@dev_submerge.ch I didn't add the same check in dsp_oss_engineinfo() because it will return EINVAL right away if no channel is found, and even if we find it, I don't think it's possible that caps->fmlist can be empty.

This revision is now accepted and ready to land.Jul 5 2024, 6:54 PM