Page MenuHomeFreeBSD
Differential D5544

rum: simplify error handling in rum_newstate()
ClosedPublic
Actions

Authored by avos on Mar 4 2016, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 6:55 AM
Unknown Object (File)
Sun, Jun 23, 1:16 PM
Unknown Object (File)
Sun, Jun 23, 1:09 PM
Unknown Object (File)
May 25 2024, 11:27 PM
Unknown Object (File)
May 25 2024, 11:24 PM
Unknown Object (File)
May 22 2024, 2:20 PM
Unknown Object (File)
May 22 2024, 6:29 AM
Unknown Object (File)
May 22 2024, 3:18 AM
View All 40 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS297169: rum: simplify error handling in rum_newstate().
Test Plan

Tested with WUSB54GC, STA mode.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

avos updated this revision to Diff 14054.Mar 4 2016, 12:04 AM
avos retitled this revision from to rum: simplify error handling in rum_newstate().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptMar 4 2016, 12:04 AM
avos added a child revision: D5546: rum: add legacy power saving support (STA mode).Mar 4 2016, 1:19 AM
adrian accepted this revision.Mar 10 2016, 5:03 PM
adrian edited edge metadata.

i'm okay with this here, but the error handling in kernel code does a lot of this kind of thing. That way the unwinding is very clear. If someone edits the code under rum_fail then it has to work correctly in both code paths (success and failure.)

So just be cautious if you decide to do big sweeping changes like this!

This revision is now accepted and ready to land.Mar 10 2016, 5:03 PM
Closed by commit rS297169: rum: simplify error handling in rum_newstate(). (authored by avos). · Explain WhyMar 21 2016, 10:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
wlan/
11 lines

Diff 14054

View Options

sys/dev/usb/wlan/if_rum.c

Loading...