rc: Disable pathname expansion when calling run_rc_command()
ClosedPublic
Actions

Authored by hrs on Jul 3 2024, 9:09 AM.

Details

Reviewers: None
Commits: rG7faddeb395b7: rc: Fix scripts that need pathname expansion
rG4deb9760a9d8: rc: Disable pathname expansion when calling run_rc_command()

Summary

Variables for command-line options like $foo_flags can contain characters
that perform pathname expansions, such as '[', ']', and '*'. They were
passed without escaping, and the matched entries in the working directory
affected the command-line options. This change turns off the expansion
when run_rc_command() is called.

While this changes the current behavior, an invocation of a service
program should not depend on entries in the working directory.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 58472
Build 55360: arc lint + arc unit

Event Timeline

hrs created this revision.Jul 3 2024, 9:09 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 3 2024, 9:09 AM

hrs requested review of this revision.Jul 3 2024, 9:09 AM

Harbormaster completed remote builds in B58472: Diff 140502.Jul 3 2024, 9:09 AM

hrs added a project: rc.Jul 3 2024, 2:41 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 12 2025, 6:20 PM

Closed by commit rG4deb9760a9d8: rc: Disable pathname expansion when calling run_rc_command() (authored by hrs). · Explain Why

This revision was automatically updated to reflect the committed changes.

hrs added a commit: rG4deb9760a9d8: rc: Disable pathname expansion when calling run_rc_command().

This change introduced a regression where my allscreens_flags settings gets ignored at boot.

In D45855#1160402, @kenrap_kennethraplee.com wrote:

This change introduced a regression where my allscreens_flags settings gets ignored at boot.

Could you explain your configuation and behavior change in more detail?

In D45855#1160497, @hrs wrote:

Could you explain your configuation and behavior change in more detail?

Sure thing. I use the following in my rc.conf which enlarges the virtual terminal fonts from being small after loading a drm-kmod driver during the booting process:

allscreens_flags="-f spleen-16x32"

After doing a src tree build upgrade today this functionality had stopped. By manually removing both set -o noglob and set +o noglob lines, I restored the original functionality.

The problem is that allscreens_flags relies on the pathname expansion in two places:
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L237-L243
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L381-L387

In D45855#1160514, @kenrap_kennethraplee.com wrote:
In D45855#1160497, @hrs wrote:

Could you explain your configuation and behavior change in more detail?

Sure thing. I use the following in my rc.conf which enlarges the virtual terminal fonts from being small after loading a drm-kmod driver during the booting process:
allscreens_flags="-f spleen-16x32"
After doing a src tree build upgrade today this functionality had stopped. By manually removing both set -o noglob and set +o noglob lines, I restored the original functionality.

The problem is that allscreens_flags relies on the pathname expansion in two places:
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L237-L243
https://github.com/freebsd/freebsd-src/blob/4deb9760a9d84d5861ee45162ffebe83f13503b8/libexec/rc/rc.d/syscons#L381-L387