Page MenuHomeFreeBSD
Differential D45769

dhclient: correct struct ifreq allocation
ClosedPublic
Actions

Authored by brooks on Jun 28 2024, 2:08 PM.
Tags
None
Referenced Files
F166853225: D45769.id.diff
Mon, Aug 17, 3:33 AM
Unknown Object (File)
Thu, Aug 13, 4:39 AM
Unknown Object (File)
Thu, Aug 13, 12:05 AM
Unknown Object (File)
Tue, Aug 11, 3:01 AM
Unknown Object (File)
Sat, Aug 8, 6:34 PM
Unknown Object (File)
Sat, Aug 8, 2:27 PM
Unknown Object (File)
Sat, Aug 8, 1:19 PM
Unknown Object (File)
Sat, Aug 8, 3:56 AM
View All Files
Subscribers
imp

Details

Reviewers
melifaro
def
Commits
rGa2e65d45a5c6: dhclient: correct struct ifreq allocation
Summary

ioctl commands such as BIOCSETIF take a struct ifreq and due to
FreeBSD's ioctl implementation copy exactly sizeof(struct ifreq) bytes
in so allocate exactly that much space.

The over-allocaton was harmless, but useless.

Reported by: def
Fixes: e2dc8d789f68a dhclient: do not add 0.0.0.0 interface alias.
Sponsored by: DARPA, AFRL

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58385
Build 55273: arc lint + arc unit

Event Timeline

brooks created this revision.Jun 28 2024, 2:08 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 28 2024, 2:08 PM
brooks requested review of this revision.Jun 28 2024, 2:08 PM
Harbormaster completed remote builds in B58385: Diff 140340.Jun 28 2024, 2:08 PM
brooks added a comment.Jun 28 2024, 2:09 PM

This was previously been fixed in f2c99d387c4770a7516237d5829b140e41a748d9 where the under allocation was potentially not harmless.

def accepted this revision.Jun 28 2024, 2:19 PM
This revision is now accepted and ready to land.Jun 28 2024, 2:19 PM
Closed by commit rGa2e65d45a5c6: dhclient: correct struct ifreq allocation (authored by brooks). · Explain WhyJul 4 2024, 11:32 AM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rGa2e65d45a5c6: dhclient: correct struct ifreq allocation.

Revision Contents
Changeset List

PathSize
sbin/
dhclient/
3 lines

Diff 140340

View Options

sbin/dhclient/dispatch.c

Loading...