arp: remove gethostby*() calls
Needs ReviewPublic
Actions

Authored by bses30074_gmail.com on Fri, Jun 14, 11:26 AM.

Details

Reviewers

hrs
lwhsu

Summary

Use getaddrinfo to replace gethostbyname and use for loop to loop the address list and copy the first meet ipv4 address.
Use getnameinfo to replace gethostbyaddr.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 58183
Build 55071: arc lint + arc unit

Event Timeline

bses30074_gmail.com created this revision.Fri, Jun 14, 11:26 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 14, 11:26 AM

bses30074_gmail.com requested review of this revision.Fri, Jun 14, 11:26 AM

Harbormaster completed remote builds in B58173: Diff 139844.Fri, Jun 14, 11:26 AM

Fix file permission.

Harbormaster completed remote builds in B58174: Diff 139845.Fri, Jun 14, 11:27 AM

bses30074_gmail.com added reviewers: hrs, lwhsu.Fri, Jun 14, 11:28 AM

bses30074_gmail.com added inline comments.Fri, Jun 14, 11:32 AM

usr.sbin/arp/arp.c
262–263	Should I use `memset` to replace the `bzero` function?

bses30074_gmail.com updated this revision to Diff 139875.Sat, Jun 15, 12:51 PM

This comment was removed by bses30074_gmail.com.

Harbormaster completed remote builds in B58183: Diff 139875.Sat, Jun 15, 12:51 PM

bses30074_gmail.com retitled this revision from arp: remove "gethostby*" function to arp: remove gethostby*() calls.Sun, Jun 16, 3:03 AM

bses30074_gmail.com edited the summary of this revision. (Show Details)

Revise error code

We should use EAI_AGAIN instead of TRY_AGAIN error code while using getnameinfo.

Harbormaster completed remote builds in B58185: Diff 139879.Sun, Jun 16, 3:20 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

arp/

arp.c

54 lines

arp_netlink.c

24 lines

Diff 139875

View Options

usr.sbin/arp/arp.c