Page MenuHomeFreeBSD
Differential D45594

arp: remove gethostby*() calls
Needs ReviewPublic
Actions

Authored by bses30074_gmail.com on Fri, Jun 14, 11:26 AM.
Tags
None
Referenced Files
F86979867: D45594.id139875.diff
Fri, Jun 28, 12:08 AM
Unknown Object (File)
Sun, Jun 16, 4:34 PM
Unknown Object (File)
Fri, Jun 14, 8:24 PM
Subscribers
imp

Details

Reviewers
hrs
lwhsu
Summary
  1. Use getaddrinfo to replace gethostbyname.
  2. Use getnameinfo with NI_NAMEREQD flag to replace gethostbyaddr.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 58185
Build 55073: arc lint + arc unit

Event Timeline

bses30074_gmail.com created this revision.Fri, Jun 14, 11:26 AM
Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 14, 11:26 AM
bses30074_gmail.com requested review of this revision.Fri, Jun 14, 11:26 AM
Harbormaster completed remote builds in B58173: Diff 139844.Fri, Jun 14, 11:26 AM
bses30074_gmail.com updated this revision to Diff 139845.Fri, Jun 14, 11:27 AM

Fix file permission.

Harbormaster completed remote builds in B58174: Diff 139845.Fri, Jun 14, 11:27 AM
bses30074_gmail.com added reviewers: hrs, lwhsu.Fri, Jun 14, 11:28 AM
bses30074_gmail.com added inline comments.Fri, Jun 14, 11:32 AM
usr.sbin/arp/arp.c
262–268

Should I use memset to replace the bzero function?

bses30074_gmail.com updated this revision to Diff 139875.Sat, Jun 15, 12:51 PM
This comment was removed by bses30074_gmail.com.
Harbormaster completed remote builds in B58183: Diff 139875.Sat, Jun 15, 12:51 PM
bses30074_gmail.com retitled this revision from arp: remove "gethostby*" function to arp: remove gethostby*() calls.Sun, Jun 16, 3:03 AM
bses30074_gmail.com edited the summary of this revision. (Show Details)
bses30074_gmail.com updated this revision to Diff 139879.Sun, Jun 16, 3:20 AM

Revise error code

We should use EAI_AGAIN instead of TRY_AGAIN error code while using getnameinfo.

Harbormaster completed remote builds in B58185: Diff 139879.Sun, Jun 16, 3:20 AM
bses30074_gmail.com marked an inline comment as not done.Tue, Jun 25, 1:05 AM
bses30074_gmail.com updated this revision to Diff 140202.Tue, Jun 25, 2:31 AM
  • Remove for loop
Harbormaster completed remote builds in B58340: Diff 140202.Tue, Jun 25, 2:31 AM
bses30074_gmail.com edited the summary of this revision. (Show Details)Tue, Jun 25, 2:32 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
arp/
51 lines
25 lines

Diff 139879

View Options

usr.sbin/arp/arp.c

Loading...
View Options

usr.sbin/arp/arp_netlink.c

Loading...