Page MenuHomeFreeBSD
Differential D45355

cross-build: This is not glibc specific, but Linux specific
ClosedPublic
Actions

Authored by imp on May 24 2024, 9:08 PM.
Tags
None
Referenced Files
F153574630: D45355.id.diff
Wed, Apr 22, 1:13 AM
Unknown Object (File)
Mon, Apr 20, 6:46 PM
Unknown Object (File)
Mon, Apr 20, 12:29 AM
Unknown Object (File)
Sun, Apr 19, 9:28 PM
Unknown Object (File)
Sun, Apr 19, 12:44 PM
Unknown Object (File)
Thu, Apr 16, 9:11 AM
Unknown Object (File)
Sun, Mar 29, 8:38 PM
Unknown Object (File)
Tue, Mar 24, 9:36 PM
View All Files
Subscribers
None

Details

Reviewers
jrtc27
val_packett.cool
Commits
rG0e03402139da: cross-build: This is not glibc specific, but Linux specific
Summary

Neither glibc nor musl define these interfaces, so provide them for all
Linux builds.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.May 24 2024, 9:08 PM
imp created this revision.
Harbormaster completed remote builds in B57909: Diff 139066.May 24 2024, 9:08 PM
imp added a parent revision: D45354: cross-build: Define __*int*_t and include sys/cdefs.h.May 24 2024, 9:08 PM
val_packett.cool accepted this revision.May 25 2024, 5:07 PM
This revision is now accepted and ready to land.May 25 2024, 5:07 PM
Closed by commit rG0e03402139da: cross-build: This is not glibc specific, but Linux specific (authored by imp). · Explain WhyMay 26 2024, 5:41 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG0e03402139da: cross-build: This is not glibc specific, but Linux specific.
jrtc27 added inline comments.May 26 2024, 6:11 PM
tools/build/cross-build/progname.c
39

The ifdef should just be dropped; Makefile.boot already makes the addition of the source file conditional on it being Linux

imp added inline comments.May 26 2024, 6:15 PM
tools/build/cross-build/progname.c
39

Ah. That's a better solution. I'd missed we'd done that. I'll do a follow-up commit. I have one or two others too.

jrtc27 added inline comments.May 26 2024, 6:31 PM
tools/build/cross-build/progname.c
39

Yeah; see the comments on the GitHub PR from myself and later Alex

imp added a comment.May 26 2024, 9:24 PM

Fixed in https://reviews.freebsd.org/D45374

imp added inline comments.May 26 2024, 9:26 PM
tools/build/cross-build/progname.c
39

I see that I missed them now...

Revision Contents
Changeset List

PathSize
tools/
build/
cross-build/
4 lines

Diff 139123

View Options

tools/build/cross-build/progname.c

Loading...