cross-build: string.h uses mode_t, so we need sys/types.h
ClosedPublic
Actions

Authored by imp on May 24 2024, 9:07 PM.

Details

Reviewers

jrtc27
val_packett.cool

Commits

rG27326f895e5f: cross-build: string.h uses mode_t, so we need sys/types.h

Summary

string.h defines strmode with a mode_t argument. POSIX states that one
must include sys/types.h to get mode_t, so do that here. This makes musl
happier. We know that sys/types.h will include sys/cdefs.h, so just
replace the latter with the former.

Co-authored-by: Val Packett <val@packett.cool>
Sponsored by: Netflix
Pull Request: https://github.com/freebsd/freebsd-src/pull/1066

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57907
Build 54795: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 24 2024, 9:07 PM

imp created this revision.

Harbormaster completed remote builds in B57907: Diff 139064.May 24 2024, 9:07 PM

imp added a parent revision: D45352: cross-build: Include sys/types.h from sys/param.h.May 24 2024, 9:08 PM

imp added a child revision: D45354: cross-build: Define __*int*_t and include sys/cdefs.h.

val_packett.cool accepted this revision.May 25 2024, 5:06 PM

This revision is now accepted and ready to land.May 25 2024, 5:06 PM

Closed by commit rG27326f895e5f: cross-build: string.h uses mode_t, so we need sys/types.h (authored by imp). · Explain WhyMay 26 2024, 5:41 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG27326f895e5f: cross-build: string.h uses mode_t, so we need sys/types.h.

Revision Contents
Changeset List

Path

Size

tools/

build/

cross-build/

include/

linux/

string.h

2 lines

Diff 139064

View Options

tools/build/cross-build/include/linux/string.h

cross-build: string.h uses mode_t, so we need sys/types.hClosedPublicActions