geom_io: Shift to pause_sbt to eliminate bogus min and update comment.
ClosedPublic
Actions

Authored by imp on May 23 2024, 4:16 PM.

Details

Reviewers

kib
jhb
markj

Commits

rG6d83b381860b: geom_io: Shift to pause_sbt to eliminate bogus min and update comment.

Summary

Update to eliminate bogus min to ensure 0 was never passed to
pause. Instead, requrest 1ms with an 'infinite' precision, which
defaults to whatever the underlying time counter can do. This should
ensure we run fairly quickly to start processing done events, while
still giving a small pause for the system to catch its breath. This rate
limiter still is less than ideal, and this commit doesn't change
that. It should really have no functional change: it just uses a better
interface to express the desired sleep.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57867
Build 54755: arc lint + arc unit

Event Timeline

imp requested review of this revision.May 23 2024, 4:16 PM

imp created this revision.

Harbormaster completed remote builds in B57867: Diff 138993.May 23 2024, 4:16 PM

imp added reviewers: kib, jhb, markj.May 23 2024, 4:17 PM

jhb added inline comments.May 23 2024, 5:23 PM

sys/geom/geom_io.c
813	I think "or one tick" is no longer true? (Or at least I still think of "tick" as a hardclock tick). The new code seems to just say "1ms".

imp added inline comments.May 23 2024, 6:22 PM

sys/geom/geom_io.c
813	Ah, timeout code rounds up if ((flags & C_HARDCLOCK) != 0 && sbt < tick_sbt) sbt = tick_sbt; but only for a hard tick. Since we're not passinc C_HARDCLOCK into this, it won't do that so that's a good catch. It is just 1ms, subject to the underlying timer's ability to deliver since we don't pass in a precision required..