Page MenuHomeFreeBSD
Differential D45096

pw: Rename some enums.
ClosedPublic
Actions

Authored by des on May 6 2024, 12:00 PM.
Tags
None
Referenced Files
F97235647: D45096.id.diff
Sat, Sep 28, 6:59 AM
F97235621: D45096.id138164.diff
Sat, Sep 28, 6:59 AM
F97235575: D45096.id138155.diff
Sat, Sep 28, 6:59 AM
Unknown Object (File)
Tue, Sep 24, 6:28 AM
Unknown Object (File)
Sat, Sep 14, 1:17 PM
Unknown Object (File)
Sun, Sep 1, 6:19 AM
Unknown Object (File)
Sat, Aug 31, 7:30 PM
Unknown Object (File)
Sat, Aug 31, 6:47 PM
View All 19 Files
Subscribers
allanjude

Details

Reviewers
• karels
imp
allanjude
Commits
rG1691bcc8b02c: pw: Rename some enums.
rGe3bd4b9288cc: pw: Rename some enums.
rG2f59ee828754: pw: Rename some enums.
rGa9ea647c29cf: pw: Rename some enums.
Summary

Rename M_PRINT and M_UPDATE to M_SHOW and M_MODIFY to match the
names of the commands they represent. No functional change intended.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57591
Build 54479: arc lint + arc unit

Event Timeline

des requested review of this revision.May 6 2024, 12:00 PM
des created this revision.
Harbormaster completed remote builds in B57591: Diff 138155.May 6 2024, 12:00 PM
des added a child revision: D45097: pw: Don't silently ignore unparsed command line arguments..May 6 2024, 12:00 PM
• karels added a comment.May 6 2024, 12:41 PM

This change is essentially cosmetic, right (reduces confusion)? If so, then adding "No functional change intended" to the message might be appropriate.

allanjude accepted this revision.May 6 2024, 1:04 PM
allanjude added a subscriber: allanjude.

I agree with karels@'s suggestion re: commit message

This revision is now accepted and ready to land.May 6 2024, 1:04 PM
des retitled this revision from pw: Minor cleanup. to pw: Rename some enums..May 6 2024, 1:20 PM
des edited the summary of this revision. (Show Details)
des edited the summary of this revision. (Show Details)
Closed by commit rGa9ea647c29cf: pw: Rename some enums. (authored by des). · Explain WhyMay 6 2024, 4:20 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGa9ea647c29cf: pw: Rename some enums..
des added a commit: rG2f59ee828754: pw: Rename some enums..May 9 2024, 1:16 PM
des added a commit: rGe3bd4b9288cc: pw: Rename some enums..
des added a commit: rG1691bcc8b02c: pw: Rename some enums..May 9 2024, 2:32 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
pw/
20 lines
4 lines
6 lines

Diff 138155

View Options

usr.sbin/pw/pw.h

Loading...
View Options

usr.sbin/pw/pw_group.c

Loading...
View Options

usr.sbin/pw/pw_user.c

Loading...