Improve code layering. These are channel functions, and so they do not
belong in pcm/sound.c.
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 57419 Build 54307: arc lint + arc unit
Event Timeline
| sys/dev/sound/pcm/channel.c | ||
|---|---|---|
| 1329 | Since ref can be negative, it would be nice to assert against underflow while you're here. i.e., if ref < 0, then we'd better have c->refcount >= -ref. | |
| sys/dev/sound/pcm/channel.c | ||
|---|---|---|
| 1329 | Wouldn't it be better to just assert than c->refcount >= 0? | |
| sys/dev/sound/pcm/channel.c | ||
|---|---|---|
| 1329 | It's generally better to assert before performing the operation, but yes that works too. | |
| sys/dev/sound/pcm/channel.c | ||
|---|---|---|
| 1329 | Actually I think what we need to do is check if c->refcount + ref >= 0, not c->refcount >= 0: KASSERT((c->refcount + ref) >= 0,
("%s(): new refcount will be negative", __func__)); | |
| sys/dev/sound/pcm/channel.c | ||
|---|---|---|
| 1329 | Seems ok to me. | |