Page MenuHomeFreeBSD
Differential D44957

tftpd: Immediately reject any request shorter than 4 bytes.
ClosedPublic
Actions

Authored by des on Apr 25 2024, 5:24 PM.
Tags
None
Referenced Files
F171255127: D44957.id137685.diff
Wed, Sep 9, 9:32 PM
F171248620: D44957.id137683.diff
Wed, Sep 9, 8:15 PM
F171217977: D44957.id137690.diff
Wed, Sep 9, 2:43 PM
F171217712: D44957.id137679.diff
Wed, Sep 9, 2:41 PM
Unknown Object (File)
Wed, Sep 9, 1:14 AM
Unknown Object (File)
Tue, Sep 8, 10:39 PM
Unknown Object (File)
Tue, Sep 8, 7:58 AM
Unknown Object (File)
Sat, Sep 5, 10:45 PM
View All Files
Subscribers
imp

Details

Reviewers
kevans
Group Reviewers
Klara
Commits
rG9f231af307b8: tftpd: Immediately reject any request shorter than 4 bytes.
Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 57371
Build 54259: arc lint + arc unit

Event Timeline

des created this revision.Apr 25 2024, 5:24 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 25 2024, 5:24 PM
des requested review of this revision.Apr 25 2024, 5:24 PM
Harbormaster completed remote builds in B57368: Diff 137679.Apr 25 2024, 5:24 PM
des added a parent revision: D44956: tftpd: Check the server status after each test..Apr 25 2024, 5:24 PM
kevans accepted this revision.Apr 25 2024, 5:47 PM
This revision is now accepted and ready to land.Apr 25 2024, 5:47 PM
des updated this revision to Diff 137683.Apr 25 2024, 5:56 PM

forgot to include include

This revision now requires review to proceed.Apr 25 2024, 5:56 PM
Harbormaster completed remote builds in B57371: Diff 137683.Apr 25 2024, 5:56 PM
kevans accepted this revision.Apr 25 2024, 6:00 PM
This revision is now accepted and ready to land.Apr 25 2024, 6:00 PM
des updated this revision to Diff 137685.Apr 25 2024, 6:16 PM

revert header change and hardcode 4

This revision now requires review to proceed.Apr 25 2024, 6:16 PM
Harbormaster completed remote builds in B57373: Diff 137685.Apr 25 2024, 6:16 PM
kevans accepted this revision.Apr 25 2024, 6:33 PM
kevans added inline comments.
libexec/tftpd/tftpd.c
231

I'd maybe just toss in a quick /* tftphdr */ to draw the connection and make it seem less arbitrary, but I do not insist

This revision is now accepted and ready to land.Apr 25 2024, 6:33 PM
Closed by commit rG9f231af307b8: tftpd: Immediately reject any request shorter than 4 bytes. (authored by des). · Explain WhyApr 25 2024, 6:36 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG9f231af307b8: tftpd: Immediately reject any request shorter than 4 bytes..
des mentioned this in rG986cceda16d8: tftpd: Use `size_t` where appropriate..May 2 2024, 9:06 AM

Revision Contents
Changeset List

PathSize
include/
arpa/
2 lines
libexec/
tftpd/
tests/
19 lines
5 lines

Diff 137683

View Options

include/arpa/tftp.h

Loading...
View Options

libexec/tftpd/tests/functional.c

Loading...
View Options

libexec/tftpd/tftpd.c

Loading...