Differential D44882

kasan: wrap kstack cleanup into a helper
AbandonedPublic
Actions

Authored by khng on Apr 19 2024, 10:29 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jul 10, 6:48 PM

	Unknown Object (File)
	Sun, Jul 6, 5:17 PM

	Unknown Object (File)
	Sat, Jul 5, 5:14 PM

	Unknown Object (File)
	Sat, Jul 5, 4:59 AM

	Unknown Object (File)
	Fri, Jul 4, 8:12 PM

	Unknown Object (File)
	Fri, Jul 4, 10:43 AM

	Unknown Object (File)
	Fri, Jul 4, 4:47 AM

	Unknown Object (File)
	Wed, Jul 2, 8:02 AM

View All 70 Files

Subscribers

Details

Reviewers

Summary

MFC with: 68a3a7fc9483
MFC after: 3 days
Sponsored by: Juniper Networks, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 57242
Build 54130: arc lint + arc unit

Event Timeline

khng created this revision.Apr 19 2024, 10:29 PM

Herald added subscribers: olce, imp. · View Herald TranscriptApr 19 2024, 10:29 PM

khng requested review of this revision.Apr 19 2024, 10:29 PM

Harbormaster completed remote builds in B57240: Diff 137426.Apr 19 2024, 10:29 PM

.

Harbormaster completed remote builds in B57242: Diff 137428.Apr 19 2024, 10:42 PM

markj added inline comments.Apr 20 2024, 2:54 PM

sys/kern/subr_asan.c
434	I'd prefer a more generic name, like kasan_kstack_init(). Or, follow the pattern of KMSAN and have kasan_thread_alloc() which only zeros the shadow of the stack (if td->td_kstack != 0).

Adapt markj@'s suggestions.

Harbormaster completed remote builds in B57251: Diff 137447.Apr 20 2024, 9:28 PM

khng marked an inline comment as done.Apr 20 2024, 9:29 PM

markj added inline comments.Apr 21 2024, 3:16 PM

sys/kern/subr_asan.c
434	Sorry, by "follow the pattern of KMSAN" I meant that kmsan_thread_alloc() and kasan_thread_alloc() calls should be in the same place. Otherwise it's rather confusing. We can actually remove the shadow space marking in vm_thread_new() as well. I posted a diff to this effect: https://reviews.freebsd.org/D44891

khng abandoned this revision.Apr 21 2024, 4:52 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

8 lines

sys/

4 lines

vm/

2 lines

Diff 137428

sys/kern/kern_fork.c

Loading...

sys/kern/subr_asan.c

Loading...

sys/sys/asan.h

Loading...

sys/vm/vm_glue.c

Loading...