Most importantly:
- Make local variables local.
- Avoid unsafe use of -a and -o operators in test expressions.
- Remove a hack intended to ease the transition from Perl 22 years ago.
MFC after: 1 week
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 57214 Build 54102: arc lint + arc unit
Event Timeline
Comment Actions
About time the FreeBSD 4.x perl compat bits went away, especially since they were not actually providing compatibility.
Comment Actions
Might want to also note that you've made a lot of variables local. I think that's a good change too, but best to note it or split it off into another commit.